Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'additionalContainers' value for flyteadmin #2834

Merged
merged 2 commits into from
Sep 1, 2022

Conversation

andrewwdye
Copy link
Contributor

This change adds an optional value to append containers to the flyteadmin containters list. This can be used to co-deploy sidecar functionality.

Verified that the following local changes

   # -- Appends additional containers to the containers list. May include template values.
-  additionalContainers: {}
+  additionalContainers:
+  - command:
+    - flyteadmin
+    - --config
+    - "{{ .Values.flyteadmin.configPath }}"
+    - ...

Produce the expected output

--- a/deployment/eks/flyte_aws_scheduler_helm_generated.yaml
+++ b/deployment/eks/flyte_aws_scheduler_helm_generated.yaml
@@ -965,6 +965,11 @@ spec:
           name: clusters-config-volume
         - mountPath: /etc/secrets/
           name: admin-secrets
+      - command:
+        - flyteadmin
+        - --config
+        - '/etc/flyte/config/*.yaml'
+        - '...'
       serviceAccountName: flyteadmin
       volumes:
         - name: db-pass

@yindia yindia merged commit 170e925 into master Sep 1, 2022
@yindia yindia deleted the extend-admin-deployment branch September 1, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants