Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] Server-side compiler should strip Type Metadata #2516

Closed
2 tasks done
EngHabu opened this issue May 20, 2022 · 1 comment · Fixed by flyteorg/flytepropeller#442 or flyteorg/flyteadmin#430
Closed
2 tasks done
Assignees
Labels
enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers
Milestone

Comments

@EngHabu
Copy link
Contributor

EngHabu commented May 20, 2022

Motivation: Why do you think this is important?

While usage of DataClasses, StructuredDataSets and parameter descriptions adds great visibility and compile-time checks for inputs/outputs, it can cause the compiled Workflow Spec to bloat.

Goal: What should the final outcome look like, ideally?

Once the compiler has validated the tasks/workflows, there is no need to store type metadata in the compiled artifacts.

Describe alternatives you've considered

Pickle

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@EngHabu EngHabu added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels May 20, 2022
@EngHabu EngHabu self-assigned this May 20, 2022
@EngHabu EngHabu added this to the 1.0.1 milestone May 20, 2022
@EngHabu EngHabu reopened this May 24, 2022
@EngHabu
Copy link
Contributor Author

EngHabu commented May 24, 2022

Need to update flyteadmin to pickup the compiler change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
1 participant