This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Strip Type Metadata #442
Merged
Strip Type Metadata #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
|
Ohh man do we want to check in all examples? |
|
Any issue with that? Regression testing? |
hamersaw
previously approved these changes
May 23, 2022
There was a problem hiding this comment.
If I understand this correctly, can we remove this section in the buildTasks function which strips annotations from the LiteralType since this PR removes them as part of the StripTypeMetadata function?
Once that is figured out, looks great! I wonder how much space this saves on the CRD.
Signed-off-by: Haytham Abuelfutuh <[email protected]>
|
Excellent point @hamersaw |
hamersaw
approved these changes
May 24, 2022
8 tasks
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
* Strip Type Metadata Signed-off-by: Haytham Abuelfutuh <[email protected]> * Strip variable descriptions Signed-off-by: Haytham Abuelfutuh <[email protected]> * Strip Description Signed-off-by: Haytham Abuelfutuh <[email protected]> * Use a fixed time for datetime field literals Signed-off-by: Haytham Abuelfutuh <[email protected]> * Move logic to strip metadata to k8s transformer Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update code documentation Signed-off-by: Haytham Abuelfutuh <[email protected]> * PR Comments Signed-off-by: Haytham Abuelfutuh <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Haytham Abuelfutuh [email protected]
TL;DR
Type
Are all requirements met?
Tracking Issue
fixes flyteorg/flyte#2516