This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Pickup compiler change to trim type metadata fields #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haytham Abuelfutuh <[email protected]>
EngHabu
requested review from
wild-endeavor,
anandswaminathan and
kumare3
as code owners
Codecov Report
@@ Coverage Diff @@
## master #430 +/- ##
=======================================
Coverage 61.33% 61.33%
=======================================
Files 156 156
Lines 11095 11095
=======================================
Hits 6805 6805
Misses 3586 3586
Partials 704 704
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
katrogan
approved these changes
May 24, 2022
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Haytham Abuelfutuh [email protected]
TL;DR
Pickup flytepropeller's compiler changes to strip type's metadata fields
Type
Tracking Issue
fixes flyteorg/flyte#2516