Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backend][Plugin] Spark Executor Pod Prefix #344

Closed
4 tasks
catalinii opened this issue Jun 4, 2020 · 1 comment
Closed
4 tasks

[Backend][Plugin] Spark Executor Pod Prefix #344

catalinii opened this issue Jun 4, 2020 · 1 comment
Labels
untriaged This issues has not yet been looked at by the Maintainers

Comments

@catalinii
Copy link
Contributor

Why would this plugin be helpful to the Flyte community
A change introduced in Spark 2.4.6 changes the executor pod name from Flyte Execution ID to use instead the spark application name. The same change is done in Spark 3.0 as well.

I have created a new PR for the spark plugin to fix this issue by setting the appropriate Spark configuration: flyteorg/flyteplugins#95

Type of Plugin

  • Web Service (e.g. AWS Sagemaker, GCP DataFlow, Qubole etc...)
  • [ x] Kubernetes Operator (e.g. TfOperator, SparkOperator, FlinkK8sOperator, etc...)
  • Customized Plugin using native kubernetes constructs
  • Other

Can you help us with the implementation?

  • [ x] Yes
  • No

Additional context
...
@catalinii catalinii added the untriaged This issues has not yet been looked at by the Maintainers label Jun 4, 2020
@catalinii catalinii mentioned this issue Jun 4, 2020
Merged
@catalinii
Copy link
Contributor Author

The PR was merged. Closing

@catalinii catalinii mentioned this issue Jun 6, 2020
Merged
5 tasks
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@hamersaw
replacing managed fields with a list of one empty instance to clear c…
189452f 
…rd managed fields (flyteorg#344)

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@anrusina
chore: cleaning up eslint rules (flyteorg#344)
481034a 
* chore: cleaning up eslint rules
* chore: remove uneeded comment
Signed-off-by: Nastya Rusina <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@SmritiSatyanV
update launch_plan.go (flyteorg#344)
04b6d52 
Archive/deactivate launch plan
[Issue](flyteorg#2776)
Signed-off-by: SmritiSatyanV [email protected]
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
@hamersaw
Adding support for environment variables set on execution (flyteorg#344)
1e0faab 
* added environment variables to TaskExecutionMetadata

Signed-off-by: Daniel Rammer <[email protected]>

* added support for environment variables

Signed-off-by: Daniel Rammer <[email protected]>

* implemented unit tests and fixed linter

Signed-off-by: Daniel Rammer <[email protected]>

---------

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@hamersaw
replacing managed fields with a list of one empty instance to clear c…
bd32547 
…rd managed fields (flyteorg#344)

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@hamersaw
Adding support for environment variables set on execution (flyteorg#344)
4b3ba97 
* added environment variables to TaskExecutionMetadata

Signed-off-by: Daniel Rammer <[email protected]>

* added support for environment variables

Signed-off-by: Daniel Rammer <[email protected]>

* implemented unit tests and fixed linter

Signed-off-by: Daniel Rammer <[email protected]>

---------

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
@SmritiSatyanV
update launch_plan.go (flyteorg#344)
727e952 
Archive/deactivate launch plan
[Issue](flyteorg#2776)
Signed-off-by: SmritiSatyanV [email protected]
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
@SmritiSatyanV @austin362667
update launch_plan.go (flyteorg#344)
a368bd9 
Archive/deactivate launch plan
[Issue](flyteorg#2776)
Signed-off-by: SmritiSatyanV [email protected]
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this issue Jul 2, 2024
@SmritiSatyanV @robert-ulbrich-mercedes-benz
update launch_plan.go (flyteorg#344)
1881e58 
Archive/deactivate launch plan
[Issue](flyteorg#2776)
Signed-off-by: SmritiSatyanV [email protected]
troychiu pushed a commit that referenced this issue Jul 8, 2024
@kamaleybov
Extra tests around secret scoping (#344)
5928ca4 
## Overview
Adds extra tests during secret injection around secret scoping. Complements https://github.com/unionai/flyte/pull/343

Context: https://unionai.slack.com/archives/C06GSLK32US/p1719350580015359?thread_ts=1719334619.426289&cid=C06GSLK32US

## Test Plan
Unit tests.

## Rollout Plan (if applicable)
N/A

## Upstream Changes
Should this change be upstreamed to OSS (flyteorg/flyte)? If not, please uncheck this box, which is used for auditing. Note, it is the responsibility of each developer to actually upstream their changes. See [this guide](https://unionai.atlassian.net/wiki/spaces/ENG/pages/447610883/Flyte+-+Union+Cloud+Development+Runbook/#When-are-versions-updated%3F).
- [ ] To be upstreamed to OSS

## Issue
https://linear.app/unionai/issue/COR-1413/injecting-secrets-is-panicing

## Checklist
* [ ] Added tests
* [ ] Ran a deploy dry run and shared the terraform plan
* [ ] Added logging and metrics
* [ ] Updated [dashboards](https://unionai.grafana.net/dashboards) and [alerts](https://unionai.grafana.net/alerting/list)
* [ ] Updated documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@catalinii