This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Set the executor prod prefix in k8s #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @catalinii thank you for the change. We usually try to create an issue (and you can definite that the problem is 2.4.6) and then associate this PR with the issue. This way when we close the milestone for the month, we automatically get changelog |
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
=======================================
Coverage 55.98% 55.99%
=======================================
Files 93 93
Lines 4794 4795 +1
=======================================
+ Hits 2684 2685 +1
Misses 1827 1827
Partials 283 283
Continue to review full report at Codecov.
|
4 tasks
|
Added flyteorg/flyte#344 |
|
LGTM 👍 |
kumare3
approved these changes
Jun 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spark 2.4.6 changed the name of the executor pod name to not contain the execution id. This PR fixes the executor name to have the flyte execution id.