Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature - UI] Support launching single tasks #459

Closed
1 of 13 tasks
EngHabu opened this issue Aug 5, 2020 · 4 comments
Closed
1 of 13 tasks

[Feature - UI] Support launching single tasks #459

EngHabu opened this issue Aug 5, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request ui Admin console user interface
Milestone

Comments

@EngHabu
Copy link
Contributor

EngHabu commented Aug 5, 2020

Motivation: Why do you think this is important?
Single tasks are becoming first-class citizens. Just like how people can launch workflows, they should be able to launch tasks using the single tasks launch API.

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

Additional context
Assumption: we will be able to use most of the UI components already developed for the launch form. If this is not the case, we should re-evaluate the priority of this work.

@EngHabu EngHabu added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Aug 5, 2020
@EngHabu EngHabu added this to the 0.7.0 milestone Aug 5, 2020
@schottra schottra added the ui Admin console user interface label Aug 10, 2020
@schottra
Copy link
Contributor

@EngHabu Do we have endpoints for launching a single task yet? If not, is there an issue tracking that work?

@EngHabu
Copy link
Contributor Author

EngHabu commented Aug 26, 2020

Yes, @katrogan can provide information about this.

@katrogan
Copy link
Contributor

katrogan commented Aug 26, 2020

@schottra yep it's completed end to end and docs are here: https://github.com/lyft/flyte/blob/master/rsts/user/features/single_task_execution.rst

for the UI to trigger a single task execution you'll want to reference a task rather than a launch plan in the create execution request spec. (we haven't rolled out renaming the field)

@schottra
Copy link
Contributor

schottra commented Oct 8, 2020

Implemented by flyteorg/flyteconsole#103
Available in flyteconsole v0.13.0

@schottra schottra closed this as completed Oct 8, 2020
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
* add data reference fields

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* combine crd parts into one object/location

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* create and pass static obj storage to propeller handler

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* read static blob at the beginning
and clear fields before updating the status

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* formatting

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* pass tests

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* remove terminated wfs' blob obj from cache

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* no return on remove blob method

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* test happy offloaded spec scenario

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* set static fields on every streak

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* formatting

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* added crdOffloadStore interface

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* made crdoffloadstore configurable

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* add metrics/formatting

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* load static workflow data outside streak loop

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* cleaned up metric reporting

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* renamed inmemory to active

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* added lruCRDOffloadStore unit tests

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* added activeCRDOffloadStore unit tests

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* added unit test for offloading crd error on handle

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* handle offloaded WorkflowClosure instead of parts of the crd

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* cache wf crd fields instead of wf closure

Signed-off-by: Babis Kiosidis <[email protected]>

* Update pkg/controller/controller.go

Co-authored-by: Ketan Umare <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* reading workflow closure directly from data store rather than cache

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* added prometheus metric

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* updated comments

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* fixed unit tests

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* fixed lint issue

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Co-authored-by: Babis Kiosidis <[email protected]>
Co-authored-by: Daniel Rammer <[email protected]>
Co-authored-by: Ketan Umare <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
* update task cache docs (flyteorg#459)

Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Qiwen Yu <[email protected]>

* update typing for Tuple

fix issue flyteorg#1710
flyteorg#1710
change typing hints from ( , ) to Tuple[ , ]

Signed-off-by: Qiwen Yu <[email protected]>

* update more Tuple typing hints

Signed-off-by: Qiwen Yu <[email protected]>

Co-authored-by: Niels Bantilan <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
* add data reference fields

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* combine crd parts into one object/location

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* create and pass static obj storage to propeller handler

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* read static blob at the beginning
and clear fields before updating the status

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* formatting

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* pass tests

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* remove terminated wfs' blob obj from cache

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* no return on remove blob method

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* test happy offloaded spec scenario

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* set static fields on every streak

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* formatting

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* added crdOffloadStore interface

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* made crdoffloadstore configurable

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* add metrics/formatting

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* load static workflow data outside streak loop

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* cleaned up metric reporting

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* renamed inmemory to active

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* added lruCRDOffloadStore unit tests

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* added activeCRDOffloadStore unit tests

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* added unit test for offloading crd error on handle

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* handle offloaded WorkflowClosure instead of parts of the crd

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* cache wf crd fields instead of wf closure

Signed-off-by: Babis Kiosidis <[email protected]>

* Update pkg/controller/controller.go

Co-authored-by: Ketan Umare <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* reading workflow closure directly from data store rather than cache

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* added prometheus metric

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* updated comments

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* fixed unit tests

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* fixed lint issue

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Co-authored-by: Babis Kiosidis <[email protected]>
Co-authored-by: Daniel Rammer <[email protected]>
Co-authored-by: Ketan Umare <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this issue Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui Admin console user interface
Projects
None yet
Development

No branches or pull requests

5 participants