Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helm dependency before kustomize build #3449

Merged
merged 1 commit into from
Mar 12, 2023
Merged

Update helm dependency before kustomize build #3449

merged 1 commit into from
Mar 12, 2023

Conversation

pingsutw
Copy link
Member

Describe your changes

Failed to build the image for single binary.

$ make build
 => => exporting manifest sha256:fd5ffa0a5cbfaf72dd4bc89f70be185c856e26656bc6b7456a87600636c0fdac                0.0s
 => => exporting config sha256:83112bc87339d549419c587008ed89b886ce3b34432ccb8a371bf58744eed15b                  0.0s
 => => sending tarball                                                                                           1.9s
mkdir -p manifests
kustomize build \
		--enable-helm \
		--load-restrictor=LoadRestrictionsNone \
		kustomize/complete > manifests/complete.yaml
Error: Error: An error occurred while checking for chart dependencies. You may need to run `helm dependency build` to fetch missing dependencies: found in Chart.yaml, but missing in charts/ directory: docker-registry, flyte-binary, kubernetes-dashboard, minio, postgresql
: unable to run: 'helm template flyte-sandbox --namespace flyte /Users/kevin/git/flyte/charts/flyte-sandbox --values /var/folders/by/42kc70lj1bb77klbhf2fmxx00000gn/T/kustomize-helm-4205539172/flyte-sandbox-kustomize-values.yaml' with env=[HELM_CONFIG_HOME=/var/folders/by/42kc70lj1bb77klbhf2fmxx00000gn/T/kustomize-helm-4205539172/helm HELM_CACHE_HOME=/var/folders/by/42kc70lj1bb77klbhf2fmxx00000gn/T/kustomize-helm-4205539172/helm/.cache HELM_DATA_HOME=/var/folders/by/42kc70lj1bb77klbhf2fmxx00000gn/T/kustomize-helm-4205539172/helm/.data] (is 'helm' installed?)
make: *** [manifests] Error 1

should run helm dependency update first.
btw, we should expose port 6443 and kubeconfig, so we will be able to connect to the k8s cluster.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

(base) ➜  sandbox-bundled git:(backend-plugin-system-grpc) ✗ make start
[ -n "flyte-sandbox" ] || \
		docker volume create flyte-sandbox
[ -n "" ] || \
		docker run --detach --rm --privileged --name flyte-sandbox \
			--add-host "host.docker.internal:host-gateway" \
			--env FLYTE_DEV=False \
			--env K3S_KUBECONFIG_OUTPUT=/.kube/kubeconfig \
			--volume /Users/kevin/git/flyte/docker/sandbox-bundled/.kube:/.kube \
			--volume /Users/kevin/.flyte/sandbox:/var/lib/flyte/config \
			--volume flyte-sandbox:/var/lib/flyte/storage \
			--publish "6443":6443 \
			--publish "30000:30000" \
			--publish "30001:30001" \
			--publish "30002:30002" \
			--publish "30080:30080" \
			flyte-sandbox:latest
2cb1c659bbaad0cb1f8bbeb5a6d1e53b569f3dabb0fab8c3170abcc77d89dcdb
export KUBECONFIG=.kube/kubeconfig
(base) ➜  sandbox-bundled git:(backend-plugin-system-grpc) ✗ k get pods
No resources found in default namespace.

Note to reviewers

@pingsutw pingsutw requested a review from jeevb March 10, 2023 23:52
--publish "30000:30000" \
--publish "30001:30001" \
--publish "30002:30002" \
--publish "30080:30080" \
$(FLYTE_SANDBOX_IMAGE)

export KUBECONFIG=.kube/kubeconfig
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not necessary. You can just use source <(make kubeconfig) instead.

@pingsutw pingsutw merged commit b82eaa5 into master Mar 12, 2023
@pingsutw pingsutw deleted the ping-3 branch March 12, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants