Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helm dependency before kustomize build #3449

Merged
merged 1 commit into from
Mar 12, 2023
Merged

Update helm dependency before kustomize build #3449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions docker/sandbox-bundled/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ flyte:
.PHONY: manifests
manifests:
mkdir -p manifests
helm dependency update ../../charts/flyte-sandbox
kustomize build \
--enable-helm \
--load-restrictor=LoadRestrictionsNone \
Expand Down Expand Up @@ -51,13 +52,13 @@ start:
--volume $(PWD)/.kube:/.kube \
--volume $(HOME)/.flyte/sandbox:/var/lib/flyte/config \
--volume flyte-sandbox:/var/lib/flyte/storage \
--publish "6443" \
--publish "6443":"6443" \
--publish "30000:30000" \
--publish "30001:30001" \
--publish "30002:30002" \
--publish "30080:30080" \
$(FLYTE_SANDBOX_IMAGE)

export KUBECONFIG=.kube/kubeconfig
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not necessary. You can just use source <(make kubeconfig) instead.

.PHONY: kubeconfig
.SILENT: kubeconfig
kubeconfig:
Expand Down
4 changes: 2 additions & 2 deletions docker/sandbox-bundled/manifests/complete.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,7 +762,7 @@ type: Opaque
---
apiVersion: v1
data:
haSharedSecret: cUFUNG5OdFBhQzNtNDhTNA==
haSharedSecret: R2ZBT0pkdGtuZ0tQeHFuSg==
proxyPassword: ""
proxyUsername: ""
kind: Secret
Expand Down Expand Up @@ -1246,7 +1246,7 @@ spec:
metadata:
annotations:
checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
checksum/secret: 0038e3c3b085694a01a9bb8080015c29d017af712e359119bd1b312fb261ffc6
checksum/secret: b7af65b89a798a2365e092b31a46eaacce978a64328b65fea14f014dee5e5d79
labels:
app: docker-registry
release: flyte-sandbox
Expand Down
4 changes: 2 additions & 2 deletions docker/sandbox-bundled/manifests/dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ metadata:
---
apiVersion: v1
data:
haSharedSecret: a25jV2szcXA0bThKek5mVw==
haSharedSecret: NjRUSFFsdTFmWTRIMjdidA==
proxyPassword: ""
proxyUsername: ""
kind: Secret
Expand Down Expand Up @@ -875,7 +875,7 @@ spec:
metadata:
annotations:
checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
checksum/secret: 36998c3b283688740f6ea909fc86fa24b4fa3886b980b61e4634ff95d27e6410
checksum/secret: 65be01926fb2783a4fb52f21e30f126a85ff29b0e0fead341247f06035e07118
labels:
app: docker-registry
release: flyte-sandbox
Expand Down