Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Update k8s Dependencies"" #4273

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

eapolinario
Copy link
Contributor

Reverts #4272

It's a revert-fest!

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (6f02b4c) 59.78% compared to head (3753a52) 59.90%.

❗ Current head 3753a52 differs from pull request most recent head 9fbb52e. Consider uploading reports for the commit 9fbb52e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4273      +/-   ##
==========================================
+ Coverage   59.78%   59.90%   +0.12%     
==========================================
  Files         641      562      -79     
  Lines       54914    40224   -14690     
==========================================
- Hits        32828    24098    -8730     
+ Misses      19502    13783    -5719     
+ Partials     2584     2343     -241     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
flytepropeller/pkg/controller/garbage_collector.go 74.31% <100.00%> (+1.51%) ⬆️
...er/pkg/controller/nodes/task/backoff/controller.go 0.00% <ø> (ø)
...eller/pkg/controller/nodes/task/backoff/handler.go 70.27% <ø> (-6.80%) ⬇️
flytepropeller/pkg/compiler/validators/utils.go 65.75% <87.50%> (+1.33%) ⬆️
flytepropeller/pkg/controller/executors/kube.go 66.66% <0.00%> (+30.55%) ⬆️
...ler/pkg/controller/nodes/task/k8s/event_watcher.go 75.00% <25.00%> (+1.15%) ⬆️
...er/pkg/controller/nodes/task/k8s/plugin_manager.go 53.51% <20.00%> (+1.21%) ⬆️
flytepropeller/pkg/controller/controller.go 11.37% <0.00%> (-0.32%) ⬇️

... and 562 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EngHabu EngHabu merged commit 5017e6c into master Oct 21, 2023
42 of 44 checks passed
@EngHabu EngHabu deleted the revert-4272-revert-4199-update-k8s-dips branch October 21, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants