Add tests in flytepropeller/pkg /controller/executors
from 72.3% to 87.3% coverage
#4276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Fixes #4209
#4273
Describe your changes
Add tests in
flytepropeller/pkg /controller/executors
to leverage coverage.Note to reviewers
In this pull request, I've introduced two new structs within
flytepropeller/pkg/controller/executors/kube_test.go
:FakeReader
andFakeObject
.Since these structs are not yet implemented in Flytepropeller, I could not generate mock objects for testing purposes.
This is the reason behind the current implementation.
Update:
Due to this revert, I have to update my test code.
Check all the applicable boxes
Screenshots
Before
After