-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artifact protos and related changes #4474
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Main pr to bring in the boilerplate code for artifact service into the main pr. Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]>
This PR adds the trigger concept. Other changes: * Forgot to make the index on artifactkey unique. * Fix to create artifact, it wasn't pulling back out the artifact key. * Updated the Artifact service to handle the passing of artifacts created by the events processor to the trigger handling components. Currently, and this is potentially a design flaw, the events processor has no way of contacting the trigger component directly. Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Most of the changes here are generated proto changes. Actual code changes are: IDL * Remove the supplemental fields in the CloudEventTaskExecution object and move them to CloudEventNodeExecution object. * Remove some fields that the artifact service ended up not using (parent_node_execution and scheduled_at) in the cloudevent publisher, change the code filling in of the aforementioned supplemental information to happen for node execution events instead of task execution events. * Remove the deleted fields. On the event handling side, move the logic to the handling of the node event instead of the task event. Signed-off-by: Yee Hing Tong <[email protected]>
* lint fixes * rename sandbox_utils without underscore Signed-off-by: Yee Hing Tong <[email protected]>
Add additional handling of pgconn * Change datacatalog logic to use flytestdlib function instead. * Change flytestdlib constants to capitalize * Add handling of the other type to Admin code directly Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: squiishyy <[email protected]>
Signed-off-by: squiishyy <[email protected]>
Signed-off-by: squiishyy <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
…lone artifact client and move into idl clientset, update local config file, remove a deprecated function (#4473) Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
…files Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
This reverts commit cfa4745. Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
This reverts commit 8ded67b. Signed-off-by: Eduardo Apolinario <[email protected]>
This reverts commit 3968d40. Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
dosubot
bot
added
size:XXL
This PR changes 1000+ lines, ignoring generated files.
enhancement
New feature or request
housekeeping
Issues that help maintain flyte and keep it tech-debt free
labels
Dec 23, 2023
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario
reviewed
Dec 26, 2023
flyteadmin/pkg/async/cloudevent/implementations/cloudevent_publisher.go
Outdated
Show resolved
Hide resolved
eapolinario
reviewed
Dec 26, 2023
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
approved these changes
Dec 27, 2023
Merged
wild-endeavor
added a commit
that referenced
this pull request
Jan 8, 2024
This is a follow up PR to the [first shell pr](#4474), which just brought in the non-artifact-service artifact changes. This PR continues with additional smaller changes. * Remove the `/data` prefix in the grpc gateway paths. Signed-off-by: Yee Hing Tong <[email protected]>
katrogan
pushed a commit
that referenced
this pull request
Jan 12, 2024
This is a follow up PR to the [first shell pr](#4474), which just brought in the non-artifact-service artifact changes. This PR continues with additional smaller changes. * Remove the `/data` prefix in the grpc gateway paths. Signed-off-by: Yee Hing Tong <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
housekeeping
Issues that help maintain flyte and keep it tech-debt free
size:XXL
This PR changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces the artifact protobufs and related control plane changes. The actual service backing artifacts is still being worked on, and related Helm chart changes and such are not yet available.
Admin changes have been feature-gated. To turn on the changes (though again, they won't work without the backend service which is coming soon), add the following to your single binary configuration.
To enable the new cloudevents
Summary of changes