Artifacts shell 2 #4649
Merged
Artifacts shell 2 #4649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up the event Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4649 +/- ##
==========================================
+ Coverage 58.10% 58.14% +0.03%
==========================================
Files 626 626
Lines 53834 53780 -54
==========================================
- Hits 31280 31270 -10
+ Misses 20048 20002 -46
- Partials 2506 2508 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
; Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: squiishyy <[email protected]>
Signed-off-by: squiishyy <[email protected]>
Signed-off-by: squiishyy <[email protected]>
squiishyy
force-pushed
the
artifacts-shell-2
branch
from
ebbbe95 to
2cbb035
Compare
Changes for tracking artifact usage upon execution start. #### Tracking tag Before create, the artifact service should write a string under the `_ua` key in the form ``` project/domain/name@version ``` where the version is the version of the artifact to be saved. At execution start, these tags are converted locally into artifact IDs containing only the artifactkey and the version (any partition information is not filled in). These IDs are then emitted alongside any artifact IDs that were the result of artifact queries, in the `CloudEventExecutionStart` event. The field in the idl has been renamed from `artifact_keys` to `artifact_trackers` to be less confusing. #### Other changes Remove an unecessary variable in registry.go file Remove the initialization sql pattern in stdlib Remove errant replace in stdlib go.mod Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: squiishyy <[email protected]>
dosubot
bot
added
the
size:XXL
dosubot
bot
added
enhancement
pingsutw
approved these changes
Jan 8, 2024
katrogan
pushed a commit
that referenced
this pull request
Jan 12, 2024
This is a follow up PR to the [first shell pr](#4474), which just brought in the non-artifact-service artifact changes. This PR continues with additional smaller changes. * Remove the `/data` prefix in the grpc gateway paths. Signed-off-by: Yee Hing Tong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up PR to the first shell pr, which just brought in the non-artifact-service artifact changes. This PR continues with additional smaller changes.
IDL changes
/dataprefix in the grpc gateway paths.DeleteTriggerchanged toDeactivateTriggerFindByWorkflowExecupdated.artifact_keystoartifact_trackersto be less confusing in theCloudEventExecutionStartevent.Tracking tag
Before create, the artifact service should write a string under the
_uakey in the formwhere the version is the version of the artifact to be saved. At execution start, these tags are converted locally into artifact IDs containing only the artifactkey and the version (any partition information is not filled in). These IDs are then emitted alongside any artifact IDs that were the result of artifact queries, in the
CloudEventExecutionStartevent.Other changes
Remove an unnecessary variable in registry.go file
Remove the initialization sql pattern in stdlib
Remove errant replace in stdlib go.mod