introduce conda-lock file for docs #4553
Conversation
dosubot
bot
added
the
size:S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4553 +/- ##
==========================================
- Coverage 58.92% 58.92% -0.01%
==========================================
Files 620 620
Lines 52432 52432
==========================================
- Hits 30896 30895 -1
- Misses 19071 19072 +1
Partials 2465 2465
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dosubot
bot
added
size:XXL
Signed-off-by: Niels Bantilan <[email protected]>
cosmicBboy
force-pushed
the
monodocs-conda-lock
branch
from
dc0ddbe to
c522bf6
Compare
Signed-off-by: Niels Bantilan <[email protected]>
| commands: | ||
| - cat monodocs-environment.lock.yaml | ||
| - mamba install -c conda-forge conda-lock | ||
| - conda-lock install -p /home/docs/monodocs-env monodocs-environment.lock.yaml | ||
| - conda info | ||
| - conda env list | ||
| - cat docs/conf.py | ||
| - cd docs && /home/docs/monodocs-env/bin/python -m sphinx -T -E -b html -d docs/_build/doctrees -D language=en . $READTHEDOCS_OUTPUT/html |
There was a problem hiding this comment.
@thomasjpfan minor risk (IMO) is that builds.command key is in beta and may change in the future.
There was a problem hiding this comment.
I tried a solution in https://github.com/thomasjpfan/conda-lock-sphinx-test, which works on readthedocs. It uses a noop.yml to create a small environment and immediately overrides it with conda-lock.
I wanted to configure it without the noop.yml, but readthedocs fails to build without it.
As long as it works, I prefer the build.command approach. If it breaks in the future, there is a workaround.
| commands: | ||
| - cat monodocs-environment.lock.yaml | ||
| - mamba install -c conda-forge conda-lock | ||
| - conda-lock install -p /home/docs/monodocs-env monodocs-environment.lock.yaml | ||
| - conda info | ||
| - conda env list | ||
| - cat docs/conf.py | ||
| - cd docs && /home/docs/monodocs-env/bin/python -m sphinx -T -E -b html -d docs/_build/doctrees -D language=en . $READTHEDOCS_OUTPUT/html |
There was a problem hiding this comment.
I tried a solution in https://github.com/thomasjpfan/conda-lock-sphinx-test, which works on readthedocs. It uses a noop.yml to create a small environment and immediately overrides it with conda-lock.
I wanted to configure it without the noop.yml, but readthedocs fails to build without it.
As long as it works, I prefer the build.command approach. If it breaks in the future, there is a workaround.
* introduce conda-lock file for docs Signed-off-by: Niels Bantilan <[email protected]> * add back _version.py Signed-off-by: Niels Bantilan <[email protected]> --------- Signed-off-by: Niels Bantilan <[email protected]> Signed-off-by: Paul Dittamo <[email protected]>
Tracking issue
https://github.com/flyteorg/flyte/issues/
Why are the changes needed?
To pin docs building dependencies.
What changes were proposed in this pull request?
conda-lockmake command to create the conda-lock filebuild.commandsto customize the readthedocs build process: https://docs.readthedocs.io/en/stable/config-file/v2.html#build-commandsHow was this patch tested?
conda-lockmake command