Add protos to support cache overrides #4820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <[email protected]>
dosubot
bot
added
size:XXL
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4820 +/- ##
=======================================
Coverage 58.98% 58.99%
=======================================
Files 645 645
Lines 55162 55162
=======================================
+ Hits 32539 32543 +4
+ Misses 20048 20046 -2
+ Partials 2575 2573 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Daniel Rammer <[email protected]>
pingsutw
previously approved these changes
Feb 5, 2024
pvditt
reviewed
Feb 6, 2024
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
pingsutw
approved these changes
Feb 9, 2024
katrogan
pushed a commit
that referenced
this pull request
Feb 20, 2024
* updated protos Signed-off-by: Daniel Rammer <[email protected]> * updated golden files Signed-off-by: Daniel Rammer <[email protected]> * removed wf yaml compiler testdata Signed-off-by: Daniel Rammer <[email protected]> * removed unecessary yaml compiler testdata Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Katrina Rogan <[email protected]>
yubofredwang
pushed a commit
to yubofredwang/flyte
that referenced
this pull request
Mar 26, 2024
* updated protos Signed-off-by: Daniel Rammer <[email protected]> * updated golden files Signed-off-by: Daniel Rammer <[email protected]> * removed wf yaml compiler testdata Signed-off-by: Daniel Rammer <[email protected]> * removed unecessary yaml compiler testdata Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: Daniel Rammer <[email protected]>
pmahindrakar-oss
pushed a commit
that referenced
this pull request
May 1, 2024
* updated protos * updated golden files * removed wf yaml compiler testdata * removed unecessary yaml compiler testdata --------- Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Daniel Rammer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
To support overriding cache metadata using
with_overrideson Flyte entities.What changes were proposed in this pull request?
Add protobuf messages that are required for this support.
How was this patch tested?
Locally / cloud.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
flyteorg/flytekit#2154
Docs link
NA