Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support overridding cache configuration #2154

Merged
merged 8 commits into from
Feb 20, 2024
Merged

Conversation

hamersaw
Copy link
Contributor

@hamersaw hamersaw commented Jan 31, 2024

Tracking issue

NA

Why are the changes needed?

Enables cache overrides.

What changes were proposed in this pull request?

^^^

How was this patch tested?

Locally.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

NA

Docs link

NA

Signed-off-by: Daniel Rammer <[email protected]>
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (80c2ff1) 85.52% compared to head (102d857) 83.02%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2154      +/-   ##
==========================================
- Coverage   85.52%   83.02%   -2.51%     
==========================================
  Files         309      309              
  Lines       23463    23494      +31     
  Branches     3631     3639       +8     
==========================================
- Hits        20067    19505     -562     
- Misses       2753     3346     +593     
  Partials      643      643              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Daniel Rammer <[email protected]>
@hamersaw hamersaw marked this pull request as ready for review February 15, 2024 20:01
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 15, 2024
hamersaw and others added 3 commits February 20, 2024 10:02
@dosubot dosubot bot added the lgtm This PR has been approved by maintainer label Feb 20, 2024
@wild-endeavor wild-endeavor merged commit 72252e7 into master Feb 20, 2024
78 of 81 checks passed
fiedlerNr9 pushed a commit that referenced this pull request Jul 25, 2024
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
@hebiao064
Copy link

Is this PR tested end to end with a workflow submission?

I've tried task.with_overrides(cache=cache, cache_version=cache_version, name="new_name") but it doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants