Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Fixes packaging for flyteidl wheel #4846

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

thomasjpfan
Copy link
Member

Tracking issue

Follow up to #4799

Why are the changes needed?

This PR fixes the pyproject.toml when building the wheel.

How was this patch tested?

Run python -m build and unzip the wheel in dist/ to see the contents.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working housekeeping Issues that help maintain flyte and keep it tech-debt free labels Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a2ce3f) 58.97% compared to head (0a556a0) 59.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4846      +/-   ##
==========================================
+ Coverage   58.97%   59.66%   +0.69%     
==========================================
  Files         644      644              
  Lines       55146    49521    -5625     
==========================================
- Hits        32521    29549    -2972     
+ Misses      20050    17398    -2652     
+ Partials     2575     2574       -1     
Flag Coverage Δ
unittests 59.34% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Thomas J. Fan <[email protected]>
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 6, 2024
@cosmicBboy cosmicBboy merged commit bfe61f9 into flyteorg:master Feb 6, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working housekeeping Issues that help maintain flyte and keep it tech-debt free lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants