Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Fixes packaging for flyteidl wheel #4846

Merged
merged 1 commit into from
Feb 6, 2024
Merged

MNT Fixes packaging for flyteidl wheel #4846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/flyteidl-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install setuptools wheel twine
pip install build twine
- name: Build and publish
env:
TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }}
TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }}
run: |
python setup.py sdist bdist_wheel
python -m build
twine upload dist/*
deploy-to-npm:
runs-on: ubuntu-latest
Expand Down
28 changes: 4 additions & 24 deletions flyteidl/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ requires-python = ">=3.8,<3.13"
dependencies = [
'googleapis-common-protos',
'protoc_gen_swagger',
'protobuf>=4.21.1,<5.0.0'
'protobuf>=4.21.1,<5.0.0',
# Packages in here should rarely be pinned. This is because these
# packages (at the specified version) are required for project
# consuming this library. By pinning to a specific version you are the
Expand Down Expand Up @@ -43,7 +43,7 @@ classifiers = [
"Topic :: Scientific/Engineering :: Artificial Intelligence",
"Topic :: Software Development",
"Topic :: Software Development :: Libraries",
"Topic :: Software Development :: Libraries :: Python Modules"
"Topic :: Software Development :: Libraries :: Python Modules",
]

[project.urls]
Expand All @@ -53,26 +53,6 @@ Homepage = "https://github.com/flyteorg/flyte/tree/master/flyteidl"
root = "../"
tag_regex = '^(?:[\w-]+/)?(?P<version>[vV]?\d+(?:\.\d+){0,2}[^\+]*)(?:\+.*)?$'

# https://github.com/pypa/setuptools/issues/3136 describes an extension to
# setuptools that would involve a simpler way to specify this, but while
# that does not happen we have to package the pyi files manually like so:
[tool.setuptools.package-data]
flyteidl = ["*.pyi", "**/*pyi"]

[tool.setuptools.packages.find]
include = ["gen/pb_python/*"]
exclude = [
"_templates",
"tmp",
"boilerplate",
"clients",
"docs",
"jsonschema",
"protos",
"scripts",
"gen/pb-cpp",
"gen/pb-go",
"gen/pb-java",
"gen/pb-js",
"gen/pb-rust",
]
where = ["gen/pb_python"]
include = ["flyteidl*"]
Loading