Add plugin_config for agent #4848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
dosubot
bot
added
size:M
Signed-off-by: Kevin Su <[email protected]>
eapolinario
approved these changes
Feb 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4848 +/- ##
==========================================
+ Coverage 58.97% 58.98% +0.01%
==========================================
Files 645 645
Lines 55162 55162
==========================================
+ Hits 32530 32539 +9
+ Misses 20058 20048 -10
- Partials 2574 2575 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
https://flyte-org.slack.com/archives/CP2HDHKE1/p1707256191123719?thread_ts=1707249775.020769&cid=CP2HDHKE1
Why are the changes needed?
Propeller try to connect to the agent even if agent is disabled.
What changes were proposed in this pull request?
Add agent plugin config only when it's enabled.
How was this patch tested?
cloud
Setup process
Screenshots
Check all the applicable boxes
Related PRs
NA
Docs link
NA