Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin_config for agent #4848

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Add plugin_config for agent #4848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
218fced
Add plugin_config for agent
pingsutw Feb 6, 2024
cbfb395
Merged master
pingsutw Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions charts/flyte-core/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,8 @@ helm install gateway bitnami/contour -n flyte
| flyteadmin.serviceMonitor.scrapeTimeout | string | `"30s"` | Sets the timeout after which request to scrape metrics will time out |
| flyteadmin.tolerations | list | `[]` | tolerations for Flyteadmin deployment |
| flyteagent.enabled | bool | `false` | |
| flyteagent.plugin_config.plugins.agentService.defaultAgent.endpoint | string | `"dns:///flyteagent.flyte.svc.cluster.local:8000"` | |
| flyteagent.plugin_config.plugins.agentService.defaultAgent.insecure | bool | `true` | |
| flyteconsole.affinity | object | `{}` | affinity for Flyteconsole deployment |
| flyteconsole.enabled | bool | `true` | |
| flyteconsole.ga.enabled | bool | `false` | |
Expand Down
5 changes: 5 additions & 0 deletions charts/flyte-core/templates/propeller/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,3 +55,8 @@ data:
task_logs.yaml: | {{ tpl (toYaml .) $ | nindent 4 }}
{{- end }}
{{- end }}
{{- if .Values.flyteagent.enabled }}
{{- with .Values.flyteagent.plugin_config }}
agent_service.yaml: | {{ tpl (toYaml .) $ | nindent 4 }}
{{- end }}
{{- end }}
11 changes: 6 additions & 5 deletions charts/flyte-core/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,12 @@ datacatalog:

flyteagent:
enabled: false
plugin_config:
plugins:
agentService:
defaultAgent:
endpoint: "dns:///flyteagent.flyte.svc.cluster.local:8000"
insecure: true

#
# FLYTEPROPELLER SETTINGS
Expand Down Expand Up @@ -752,11 +758,6 @@ configmap:
# DEFAULT_ENV_VAR: VALUE
default-cpus: 100m
default-memory: 100Mi
# Uncomment and modify to include configuration for Flyte Agent
# agent-service:
# defaultGrpcEndpoint: flyteagent.flyte.svc.cluster.local:8000
# supportedTaskTypes:
# - bigquery_query_job_task
remoteData:
remoteData:
region: "us-east-1"
Expand Down
Loading
Loading