Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[House Keeping] deprecate MaxDatasetSizeBytes propeller config in favor of GetLimitMegabytes storage config #4852

Merged
merged 5 commits into from
Mar 21, 2024
Merged

[House Keeping] deprecate MaxDatasetSizeBytes propeller config in favor of GetLimitMegabytes storage config #4852

merged 5 commits into from
Mar 21, 2024

Conversation

pvditt
Copy link
Contributor

@pvditt pvditt commented Feb 7, 2024 •
edited
Loading

Tracking issue

#4487

Why are the changes needed?

  • decrease confusion when adjusting the maximum size for storing a blob file

What changes were proposed in this pull request?

  • deprecate max-output-size-bytes propeller config in favor of maxDownloadMBs storage config

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@codecov Codecov
Copy link

codecov bot commented Feb 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 58.97%. Comparing base (04dc245) to head (621a1d5).
Report is 2 commits behind head on master.

Files Patch % Lines
flytepropeller/pkg/controller/controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4852   +/-   ##
=======================================
  Coverage   58.97%   58.97%           
=======================================
  Files         645      645           
  Lines       55578    55590   +12     
=======================================
+ Hits        32778    32786    +8     
- Misses      20207    20209    +2     
- Partials     2593     2595    +2
Flag Coverage Δ
unittests 58.97% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pvditt pvditt marked this pull request as ready for review March 16, 2024 01:30
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. documentation Improvements or additions to documentation housekeeping Issues that help maintain flyte and keep it tech-debt free labels Mar 16, 2024
@pvditt pvditt requested a review from hamersaw March 16, 2024 01:35
neverett
neverett previously approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@neverett neverett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs changes look good to me, thanks!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 19, 2024
@pvditt
oof
621a1d5 
Signed-off-by: Paul Dittamo <[email protected]>
hamersaw
hamersaw approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@hamersaw hamersaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to go a level deeper here and strip out the MaxDatasetSizeBytes in NodeExecutionContext? This is just used to restrict file sizes and now that we are setting it to the thing as blobstore limits we are doing this check twice: (1) blobstore read and (2) maxPayloadSize in RemoteFileOutputReader. OK either way, but should at least mention that there is some dead code here.

@pvditt
Copy link
Contributor Author

pvditt commented Mar 21, 2024

@hamersaw yup that makes sense. I'll make a follow up PR to handle that.

@pvditt pvditt merged commit 2db8eed into master Mar 21, 2024
47 of 48 checks passed
@pvditt pvditt deleted the housekeeping/single-store-config branch March 21, 2024 18:22
@pvditt pvditt mentioned this pull request Mar 21, 2024
Merged
3 tasks
yubofredwang pushed a commit to yubofredwang/flyte that referenced this pull request Mar 26, 2024
@pvditt @yubofredwang
[House Keeping] deprecate MaxDatasetSizeBytes propeller config in fav…
8891359 
…or of GetLimitMegabytes storage config (flyteorg#4852)

* deprecate MaxDatasetSizeBytes propeller config in favor of GetLimitMegabytes storage config

Signed-off-by: Paul Dittamo <[email protected]>

* update config docs

Signed-off-by: Paul Dittamo <[email protected]>

* update deprecation message

Signed-off-by: Paul Dittamo <[email protected]>

* oof

Signed-off-by: Paul Dittamo <[email protected]>

---------

Signed-off-by: Paul Dittamo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamersaw hamersaw hamersaw approved these changes

@neverett neverett neverett left review comments

@ppiegaze ppiegaze Awaiting requested review from ppiegaze

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation housekeeping Issues that help maintain flyte and keep it tech-debt free lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pvditt @neverett @hamersaw