Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[House Keeping] deprecate MaxDatasetSizeBytes propeller config in favor of GetLimitMegabytes storage config #4852

Merged
merged 5 commits into from
Mar 21, 2024
Merged

[House Keeping] deprecate MaxDatasetSizeBytes propeller config in favor of GetLimitMegabytes storage config #4852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dffb7b6
deprecate MaxDatasetSizeBytes propeller config in favor of GetLimitMe…
pvditt Feb 7, 2024
6850797
update config docs
pvditt Feb 7, 2024
41045f1
Merge branch 'master' into housekeeping/single-store-config
pvditt Mar 16, 2024
1a5c329
update deprecation message
pvditt Mar 16, 2024
621a1d5
oof
pvditt Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/deployment/configuration/generated/flyteadmin_config.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3522,13 +3522,13 @@ Enable events publishing to K8s events API.
max-output-size-bytes (int64)
------------------------------------------------------------------------------------------------------------------------

Maximum size of outputs per task
Deprecated! Use storage.limits.maxDownloadMBs instead

**Default Value**:

.. code-block:: yaml

"10485760"
"-1"


enable-grpc-latency-metrics (bool)
Expand Down
4 changes: 2 additions & 2 deletions docs/deployment/configuration/generated/flytepropeller_config.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4166,13 +4166,13 @@ Enable events publishing to K8s events API.
max-output-size-bytes (int64)
------------------------------------------------------------------------------------------------------------------------

Maximum size of outputs per task
Deprecated! Use storage.limits.maxDownloadMBs instead

**Default Value**:

.. code-block:: yaml

"10485760"
"-1"


enable-grpc-latency-metrics (bool)
Expand Down
4 changes: 2 additions & 2 deletions docs/deployment/configuration/generated/scheduler_config.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3522,13 +3522,13 @@ Enable events publishing to K8s events API.
max-output-size-bytes (int64)
------------------------------------------------------------------------------------------------------------------------

Maximum size of outputs per task
Deprecated! Use storage.limits.maxDownloadMBs instead

**Default Value**:

.. code-block:: yaml

"10485760"
"-1"


enable-grpc-latency-metrics (bool)
Expand Down
4 changes: 2 additions & 2 deletions flytepropeller/pkg/controller/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ var (
GCInterval: config.Duration{
Duration: 30 * time.Minute,
},
MaxDatasetSizeBytes: 10 * 1024 * 1024,
MaxDatasetSizeBytes: -1,
Queue: CompositeQueueConfig{
Type: CompositeQueueBatch,
BatchingInterval: config.Duration{
Expand Down Expand Up @@ -142,7 +142,7 @@ type Config struct {
GCInterval config.Duration `json:"gc-interval" pflag:"Run periodic GC every 30 minutes"`
LeaderElection LeaderElectionConfig `json:"leader-election,omitempty" pflag:",Config for leader election."`
PublishK8sEvents bool `json:"publish-k8s-events" pflag:",Enable events publishing to K8s events API."`
MaxDatasetSizeBytes int64 `json:"max-output-size-bytes" pflag:",Maximum size of outputs per task"`
MaxDatasetSizeBytes int64 `json:"max-output-size-bytes" pflag:",Deprecated! Use storage.limits.maxDownloadMBs instead"`
EnableGrpcLatencyMetrics bool `json:"enable-grpc-latency-metrics" pflag:",Enable grpc latency metrics. Note Histograms metrics can be expensive on Prometheus servers."`
KubeConfig KubeClientConfig `json:"kube-client-config" pflag:",Configuration to control the Kubernetes client"`
NodeConfig NodeConfig `json:"node-config,omitempty" pflag:",config for a workflow node"`
Expand Down
2 changes: 1 addition & 1 deletion flytepropeller/pkg/controller/config/config_flags.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion flytepropeller/pkg/controller/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@
}

nodeExecutor, err := nodes.NewExecutor(ctx, cfg.NodeConfig, store, controller.enqueueWorkflowForNodeUpdates, eventSink,
launchPlanActor, launchPlanActor, cfg.MaxDatasetSizeBytes, storage.DataReference(cfg.DefaultRawOutputPrefix), kubeClient,
launchPlanActor, launchPlanActor, sCfg.Limits.GetLimitMegabytes*1024*1024, storage.DataReference(cfg.DefaultRawOutputPrefix), kubeClient,

Check warning on line 442 in flytepropeller/pkg/controller/controller.go

View check run for this annotation

Codecov / codecov/patch

flytepropeller/pkg/controller/controller.go#L442 

Added line #L442 was not covered by tests
catalogClient, recoveryClient, &cfg.EventConfig, cfg.ClusterID, signalClient, nodeHandlerFactory, scope)
if err != nil {
return nil, errors.Wrapf(err, "Failed to create Controller.")
Expand Down
Loading