Shallow copying EnvironmentVariables map before injecting ArrayNode env vars #5182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
fixes #5171
Why are the changes needed?
In ArrayNode executions where the execution context has environment variables each subNode evaluation will attempt to inject maptask specific variables into the same map. This is because golang passes all maps by reference.
What changes were proposed in this pull request?
In this PR we updated the arrayExecutionContext to shallow copy existing environment variables so each subNode evaluation maintains their own replica before injecting maptask specific environment variables. This ensures that there can not be concurrent map writes in the case of parallelized subNode evaluations.
How was this patch tested?
Printed memory addresses of
EnvironmentVariables
map before and after change and viewed a change.Setup process
NA
Screenshots
NA
Check all the applicable boxes
Related PRs
NA
Docs link
NA