Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shallow copying EnvironmentVariables map before injecting ArrayNode env vars #5182

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Shallow copying EnvironmentVariables map before injecting ArrayNode env vars #5182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions flytepropeller/pkg/controller/nodes/array/execution_context.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,18 @@ func (a *arrayExecutionContext) GetExecutionConfig() v1alpha1.ExecutionConfig {

func newArrayExecutionContext(executionContext executors.ExecutionContext, subNodeIndex int) *arrayExecutionContext {
executionConfig := executionContext.GetExecutionConfig()
if executionConfig.EnvironmentVariables == nil {
executionConfig.EnvironmentVariables = make(map[string]string)

// since maps are all reference types in golang if we are going to modify the
// EnvironmentVariables for each subNode we need to at least shallow copy the map to ensure
// there are no concurrent modifications during parallelized evaluation of subNodes
environmentVariables := executionConfig.EnvironmentVariables
executionConfig.EnvironmentVariables = make(map[string]string)
for key, value := range environmentVariables {
executionConfig.EnvironmentVariables[key] = value
}
executionConfig.EnvironmentVariables[JobIndexVarName] = FlyteK8sArrayIndexVarName
executionConfig.EnvironmentVariables[FlyteK8sArrayIndexVarName] = strconv.Itoa(subNodeIndex)

executionConfig.MaxParallelism = 0 // hardcoded to 0 because parallelism is handled by the array node

return &arrayExecutionContext{
Expand Down
Loading