Update flytekit tag #5360
Merged
Update flytekit tag #5360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5360 +/- ##
==========================================
+ Coverage 61.09% 61.10% +0.01%
==========================================
Files 794 794
Lines 51213 51213
==========================================
+ Hits 31288 31294 +6
+ Misses 17044 17038 -6
Partials 2881 2881
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eapolinario
reviewed
May 15, 2024
| @@ -2,7 +2,8 @@ | |||
|
|
|||
| set -ex | |||
|
|
|||
| FLYTEKIT_TAG=$(curl --silent "https://api.github.com/repos/flyteorg/flytekit/releases/latest" | jq -r .tag_name | sed 's/^v//') | |||
| # NOTE: Flyte and flytekit should be released at the same time. If not, Flyte chart will use a flyteagent image that does not exist. | |||
| FLYTEKIT_TAG=$(echo "${VERSION}" | sed 's/^v//') | |||
There was a problem hiding this comment.
do we need to drop the v from the tag?
eapolinario
approved these changes
May 15, 2024
| @@ -2,7 +2,8 @@ | |||
|
|
|||
| set -ex | |||
|
|
|||
| FLYTEKIT_TAG=$(curl --silent "https://api.github.com/repos/flyteorg/flytekit/releases/latest" | jq -r .tag_name | sed 's/^v//') | |||
| # NOTE: Flyte and flytekit should be released at the same time. If not, Flyte chart will use a flyteagent image that does not exist. | |||
| FLYTEKIT_TAG=$(echo "${VERSION}" | sed 's/^v//') | |||
3 tasks
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
Signed-off-by: Kevin Su <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
https://flyte-org.slack.com/archives/CP2HDHKE1/p1715374736546419
Why are the changes needed?
The version of the flyteagent tag is not aligned with other flyte components (flytepropeller, flyteadmin, etc)
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
NA
Docs link
NA