Retag flyteagent image upon release #5509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5509 +/- ##
=======================================
Coverage 60.98% 60.99%
=======================================
Files 794 794
Lines 51475 51475
=======================================
+ Hits 31392 31397 +5
+ Misses 17191 17186 -5
Partials 2892 2892
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Eduardo Apolinario <[email protected]>
wild-endeavor
previously approved these changes
Jun 25, 2024
Signed-off-by: Eduardo Apolinario <[email protected]>
pingsutw
approved these changes
Jun 25, 2024
3 tasks
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
* Retag flyteagent image upon release Signed-off-by: Eduardo Apolinario <[email protected]> * Run make helm Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
vlibov
pushed a commit
to vlibov/flyte
that referenced
this pull request
Aug 16, 2024
* Retag flyteagent image upon release Signed-off-by: Eduardo Apolinario <[email protected]> * Run make helm Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
In #5360 we made a decision to join flytekit and Flyte releases, but that turned out to be too inflexible.
What changes were proposed in this pull request?
In this PR we decouple the versions of the flyteagent from the Flyte release versions. Instead, we follow a similar scheme as the one we use for flyteconsole and upon releases we retag the latest flyteagent docker image.
On releases we retag the images by adding the suffix
-releaseto each component image. We're going to do the same with flyteagent images, which are published on flytekit releases.How was this patch tested?
Running
VERSION=1.99.0 make release_automationfrom the root of the repo updated all helm charts, including the flyteagent image (to 1.12.3, which is the latest flytekit image at the time of this PR).Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link