Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] JSON IDL V2 #5735

Closed
wants to merge 4 commits into from

use JSON IDL object in resolveAttrPathInJSON

dd21c31
Select commit
Loading
Failed to load commit list.
Closed

[wip] JSON IDL V2 #5735

use JSON IDL object in resolveAttrPathInJSON
dd21c31
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 11, 2024 in 0s

36.18% (-0.04%) compared to 89efcc6

View this Pull Request on Codecov

36.18% (-0.04%) compared to 89efcc6

Details

Codecov Report

Attention: Patch coverage is 4.81928% with 158 lines in your changes missing coverage. Please review.

Project coverage is 36.18%. Comparing base (89efcc6) to head (dd21c31).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
flyteidl/gen/pb-go/flyteidl/core/literals.pb.go 4.54% 105 Missing ⚠️
...opeller/pkg/controller/nodes/attr_path_resolver.go 5.76% 47 Missing and 2 partials ⚠️
flytepropeller/pkg/compiler/validators/typing.go 0.00% 1 Missing and 1 partial ⚠️
flytepropeller/pkg/compiler/validators/utils.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5735      +/-   ##
==========================================
- Coverage   36.21%   36.18%   -0.04%     
==========================================
  Files        1303     1303              
  Lines      109568   109663      +95     
==========================================
  Hits        39683    39683              
- Misses      65764    65857      +93     
- Partials     4121     4123       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov