Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve literal type string representation handling #5932

Merged
merged 16 commits into from
Nov 1, 2024
+65 −6

lint

e5c2af1
Select commit
Loading
Failed to load commit list.
Merged

Improve literal type string representation handling #5932

lint
e5c2af1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 29, 2024 in 0s

36.82% (-0.03%) compared to 13b3d82

View this Pull Request on Codecov

36.82% (-0.03%) compared to 13b3d82

Details

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 36.82%. Comparing base (13b3d82) to head (e5c2af1).

Files with missing lines Patch % Lines
...epropeller/pkg/compiler/transformers/k8s/inputs.go 0.00% 1 Missing ⚠️
flytepropeller/pkg/compiler/validators/bindings.go 66.66% 1 Missing ⚠️
...lytepropeller/pkg/compiler/validators/condition.go 0.00% 1 Missing ⚠️
flytepropeller/pkg/compiler/validators/vars.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5932      +/-   ##
==========================================
- Coverage   36.84%   36.82%   -0.03%     
==========================================
  Files        1309     1310       +1     
  Lines      130967   130979      +12     
==========================================
- Hits        48252    48229      -23     
- Misses      78531    78572      +41     
+ Partials     4184     4178       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov