This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Plugins for flyteadmin server middleware #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
katrogan
requested review from
wild-endeavor,
anandswaminathan,
EngHabu and
kumare3
as code owners
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
==========================================
+ Coverage 61.18% 61.29% +0.11%
==========================================
Files 154 155 +1
Lines 11081 11090 +9
==========================================
+ Hits 6780 6798 +18
+ Misses 3597 3588 -9
Partials 704 704
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
katrogan
changed the title
Signed-off-by: Katrina Rogan <[email protected]>
EngHabu
approved these changes
May 18, 2022
katrogan
pushed a commit
that referenced
this pull request
May 19, 2022
This reverts commit d0bda09.
katrogan
pushed a commit
that referenced
this pull request
May 19, 2022
This reverts commit d0bda09. Signed-off-by: Katrina Rogan <[email protected]>
katrogan
pushed a commit
that referenced
this pull request
May 19, 2022
This reverts commit d0bda09. Signed-off-by: Katrina Rogan <[email protected]>
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
This reverts commit c1489d8. Signed-off-by: Katrina Rogan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Enables flexibility in flyteadmin serving, such as custom authentication/audit logging middleware, authorization hooks and more
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
fixes flyteorg/flyte#2507
Follow-up issue
NA