Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Revert "Plugins for flyteadmin server middleware" #427

Merged
merged 1 commit into from
May 19, 2022
Merged

Conversation

katrogan
Copy link
Contributor

Reverts #420

EngHabu
EngHabu previously approved these changes May 19, 2022
This reverts commit d0bda09.

Signed-off-by: Katrina Rogan <[email protected]>
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #427 (e89bd16) into master (c0e62f4) will decrease coverage by 0.11%.
The diff coverage is n/a.

❗ Current head e89bd16 differs from pull request most recent head 0b8603d. Consider uploading reports for the commit 0b8603d to get more accurate results

@@            Coverage Diff             @@
##           master     #427      +/-   ##
==========================================
- Coverage   61.32%   61.21%   -0.12%     
==========================================
  Files         156      155       -1     
  Lines       11097    11088       -9     
==========================================
- Hits         6805     6787      -18     
- Misses       3588     3597       +9     
  Partials      704      704              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/rpc/adminservice/base.go 4.12% <ø> (+0.08%) ⬆️
plugins/registry.go 100.00% <ø> (ø)
auth/identity_context.go 0.00% <0.00%> (-29.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0e62f4...0b8603d. Read the comment docs.

@katrogan katrogan merged commit ede2297 into master May 19, 2022
@katrogan katrogan deleted the revert-420-authz branch May 19, 2022 19:55
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants