This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
wild-endeavor
requested review from
katrogan,
anandswaminathan,
EngHabu,
kumare3 and
pmahindrakar-oss
as code owners
September 30, 2022 00:13
Codecov Report
@@ Coverage Diff @@
## master #480 +/- ##
==========================================
+ Coverage 61.62% 61.64% +0.02%
==========================================
Files 158 158
Lines 11293 11484 +191
==========================================
+ Hits 6959 7079 +120
- Misses 3615 3671 +56
- Partials 719 734 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: pmahindrakar-oss <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
pmahindrakar-oss
approved these changes
Oct 2, 2022
Merged
8 tasks
8 tasks
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Add the project level as a matchable resource. This implements the change IDL pr. Project-level settings will sit at a lower level of specificity than project-domain. The idea is that the front end will issue two queries, one for the project domain level (which it does already today) and one for the project level. The front end will be responsible for merging the results of these two calls.
Type
Are all requirements met?
Complete description
Get()
call to take into account an empty string for the domain.iface.go
and the merge function went intoutil/shared.go
getExecutionConfig
Other changes:
ResourceInterface
for the resource manager to support the three new APIs.ResourceRepoInterface
to support a call that is scoped to the project levelGetProjectLevel
ResourcePriorityDomainLevel
and add a project one. Use a higher number in case we one day do want to use an even lower one.MergeUpdateProjectDomainAttributes
function more general - useadmin.MatchingAttributes
instead ofadmin.ProjectDomainAttributes
.Tracking Issue
This is a patch fix for
flyteorg/flyte#2322
It's okay to keep the IDL changes since those make sense more broadly, but the code to merge in system level defaults will need to be removed after the broader settings project is complete.