This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Project level attributes via matchable resource #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
=======================================
Coverage 75.04% 75.04%
=======================================
Files 18 18
Lines 1162 1162
=======================================
Hits 872 872
Misses 237 237
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Yee Hing Tong <[email protected]>
wild-endeavor
changed the title
Signed-off-by: Yee Hing Tong <[email protected]>
wild-endeavor
changed the title
Signed-off-by: Yee Hing Tong <[email protected]>
8 tasks
pmahindrakar-oss
approved these changes
Sep 28, 2022
EngHabu
approved these changes
Sep 29, 2022
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
* copy pasta Signed-off-by: Yee Hing Tong <[email protected]> * generate Signed-off-by: Yee Hing Tong <[email protected]> * fix comment Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: Yee Hing Tong <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This IDL change implements a partial solution to the broader settings project. The main purpose of this change is to get this section of the project domain view to show up all the time.
Having project-level matchable resources also makes sense in the long run. This PR adds
GetProjectAttributesUpdateProjectAttributesDeleteProjectAttributesType
Are all requirements met?
Complete description
This is a looser (lower specificity) version of the project-domain settings.
Tracking Issue
See comment above.