Adds WorkflowSelector #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vior on text input
mrmcduff
approved these changes
Aug 27, 2019
| @@ -0,0 +1,11 @@ | |||
| export function resolveAfter<T>(waitMs: number, value: T): Promise<T> { | |||
There was a problem hiding this comment.
Are these functions meant only for use in storyboards? If so, just wanted to check if they should exist in a different folder, since I'd imagine /common as being for more shared tools.
There was a problem hiding this comment.
My thought in putting them here was that they are generally useful utility functions. But they are currently only used in storybook code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the mixed-behavior workflow selector for the Launch form.
The selector takes a list of default options to be shown if the selector is triggered. It also allows the user to type in a search term, which will be auto-completed once it passes 4 characters by calling a provided fetch function. Canceling the search by blurring or hitting escape will restore the current selection. The fetch function is only invoked after the user has ceased typing for 500ms.
Note: Most of the implementation of this component could be made generic. I'll do that once I need to use it again.
WorkflowSelectorcomponent.WorkflowSelector.useDebouncedValuehook, which will debounce updates to a given value until the last change happened after a specified interval.Workflowrecords with generated version strings.createMockFetchableto allow it to be used outside of tests (also useful in stories)