Adds support for launching workflows #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vior on text input
Adds WorkflowSelector
Wiring up form state and value conversion on submission
Adds Launch Plan selector
Integrate the Launch form
mrmcduff
previously approved these changes
Sep 4, 2019
|
|
||
| const NoResultsContent: React.FC = () => ( | ||
| <MenuItem className={useStyles().placeholderResult} disabled={true}> | ||
| No results found. |
There was a problem hiding this comment.
Do we need to wrap this so it gets translated when we include i18n?
There was a problem hiding this comment.
So far there are no plans to do i18n. If we decide to do it, there will likely be an audit of all bare strings and we can figure out what to wrap it with then.
|
+1 |
mrmcduff
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the code for this branch has been reviewed in previous PRs. See #1, #2, #3, #4.