Graph ux feature add legend #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Porter <[email protected]>
Signed-off-by: Jason Porter <[email protected]>
jsonporter
force-pushed
the
GraphUX-feature-add-legend
branch
from
e882cf4 to
24e9c20
Compare
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
=========================================
Coverage ? 65.58%
=========================================
Files ? 355
Lines ? 7442
Branches ? 1264
=========================================
Hits ? 4881
Misses ? 2561
Partials ? 0 Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 0.25.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
jsonporter
added a commit
that referenced
this pull request
Sep 17, 2021
* Checkin and merge to master Signed-off-by: Jason Porter <[email protected]> * fixed one more Signed-off-by: Jason Porter <[email protected]>
jsonporter
added a commit
that referenced
this pull request
Sep 17, 2021
* Checkin and merge to master Signed-off-by: Jason Porter <[email protected]> * fixed one more Signed-off-by: Jason Porter <[email protected]>
jsonporter
added a commit
that referenced
this pull request
Sep 17, 2021
* feat: add workflow versions table Signed-off-by: csirius <[email protected]> Signed-off-by: Jason Porter <[email protected]> * chore(release): Release 0.25.0 [skip ci] # [0.25.0](http://github.com/lyft/flyteconsole/compare/v0.24.0...v0.25.0) (2021-08-31) ### Features * add workflow versions table ([#193](http://github.com/lyft/flyteconsole/issues/193)) ([6fff87e](http://github.com/lyft/flyteconsole/commit/6fff87e40007fd15faae634eb6402045c067dd2c)) Signed-off-by: Jason Porter <[email protected]> * improvement: show proper error message for aborted workflows (#195) * improvement: show proper error message for aborted workflows Signed-off-by: Pianist038801 <[email protected]> * improvement: show abort message in the execution list Signed-off-by: Pianist038801 <[email protected]> Co-authored-by: Pianist038801 <[email protected]> Signed-off-by: Jason Porter <[email protected]> * Fix/versions executions gap (#197) * feat: add workflow versions table Signed-off-by: csirius <[email protected]> * fix: space between versions and executions table Signed-off-by: csirius <[email protected]> Signed-off-by: Jason Porter <[email protected]> * feat: workflow version details page Signed-off-by: csirius <[email protected]> Signed-off-by: Jason Porter <[email protected]> * Pre merge checkin Signed-off-by: Jason Porter <[email protected]> * fix: this is rfc, do not deploy until resolved; details in comments (#172) * fix: this is rfc, do not deploy until resolved; details in comments Signed-off-by: Jason Porter <[email protected]> * fix: this is rfc, do not deploy until resolved; details in comments note: deploying with caution; the believe if that it was incorrect to use meta. Signed-off-by: Jason Porter <[email protected]> * fix: show field types on json launch form (#199) Signed-off-by: Pianist038801 <[email protected]> Co-authored-by: Pianist038801 <[email protected]> Signed-off-by: Jason Porter <[email protected]> * chore(release): Release 0.25.1 [skip ci] ## [0.25.1](http://github.com/lyft/flyteconsole/compare/v0.25.0...v0.25.1) (2021-09-13) ### Bug Fixes * show field types on json launch form ([#199](http://github.com/lyft/flyteconsole/issues/199)) ([a42b9f8](http://github.com/lyft/flyteconsole/commit/a42b9f8520fcd24dee752111e606ad9ae9bd88f5)) * this is rfc, do not deploy until resolved; details in comments ([#172](http://github.com/lyft/flyteconsole/issues/172)) ([67dd183](http://github.com/lyft/flyteconsole/commit/67dd18397caf40e350da40e0672e500eaa9f338a)) Signed-off-by: Jason Porter <[email protected]> * Minor fixes Signed-off-by: Jason Porter <[email protected]> * Feat/version details (#198) * feat: add workflow versions table Signed-off-by: csirius <[email protected]> * feat: workflow version details page Signed-off-by: csirius <[email protected]> Signed-off-by: Jason Porter <[email protected]> * fix: repopulate struct input fields on relaunch form (#201) Signed-off-by: Pianist038801 <[email protected]> Co-authored-by: Pianist038801 <[email protected]> Signed-off-by: Jason Porter <[email protected]> * Graph ux feature add legend (#196) * Checkin and merge to master Signed-off-by: Jason Porter <[email protected]> * fixed one more Signed-off-by: Jason Porter <[email protected]> * chore(release): Release 0.25.2 [skip ci] ## [0.25.2](http://github.com/lyft/flyteconsole/compare/v0.25.1...v0.25.2) (2021-09-16) ### Bug Fixes * repopulate struct input fields on relaunch form ([#201](http://github.com/lyft/flyteconsole/issues/201)) ([950e080](http://github.com/lyft/flyteconsole/commit/950e080a2c52c6294630f0ffd1410b0e45b50a8d)) Signed-off-by: Jason Porter <[email protected]> * final before pr Signed-off-by: Jason Porter <[email protected]> * Fixed issues created by bad rebase Signed-off-by: Jason Porter <[email protected]> * Fixed more merge issues Signed-off-by: Jason Porter <[email protected]> Co-authored-by: csirius <[email protected]> Co-authored-by: flyte bot <[email protected]> Co-authored-by: pianist <[email protected]> Co-authored-by: Pianist038801 <[email protected]> Co-authored-by: csirius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new functionality to the GraphUX as well as addresses some bug fixes.
Note: This feature is still in progress so there is some code included that has been commented out for future work.
Type
Are all requirements met?
Complete description
The two big changes here were changing the way that nodeExecutions are mapped to now include 'scopedId' as well as adding an estimation step for nested graph dimensions. It should be noted that the bug involving scopedId is application-wide and effects many components however this PR is a quick fix scoped only to cases involving the graph. The full refactor is being picked up in this sprint as part of flyteorg/flyte#1085
Tracking Issue
NA
Follow-up issue
NA