fix: show field types on json launch form #199

Pianist038801 · 2021-09-10T18:02:35Z

This PR makes JSON Launch Form show field types like other inputs.

Type

Bug Fix
Feature
Plugin

Are all requirements met?

Tracking Issue

fixes flyteorg/flyte#1419

codecov · 2021-09-10T18:07:41Z

Codecov Report

❗ No coverage uploaded for pull request base (master@ff0df39). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #199   +/-   ##
=========================================
  Coverage          ?   65.97%           
=========================================
  Files             ?      354           
  Lines             ?     7407           
  Branches          ?     1256           
=========================================
  Hits              ?     4887           
  Misses            ?     2520           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff0df39...d7368f2. Read the comment docs.

govalt · 2021-09-10T19:50:43Z

src/components/Launch/LaunchForm/StructInput.tsx

+
+    if (keys.includes('title')) {
+        const { title, type, format } = data;
+        data['title'] = `${title} (${format ? format : type})`;


what about to use ${format ?? type} instead?

That’s a good catch, David. I just forgot to replace it with '??' as I wrote separate .js file to write this function. When I used in .js file, it was throwing an error saying SyntaxError: Unexpected token '?'

Will push a fix ASAP.

I think the error is thrown coz the js file was not using ES6 or later versions.
For ts, it's okay. :)

govalt · 2021-09-10T19:53:53Z

src/components/Launch/LaunchForm/StructInput.tsx

+    if (keys.includes('title')) {
+        const { title, type, format } = data;
+        data['title'] = `${title} (${format ? format : type})`;
+        if (!keys.includes('additionalProperties')) return data;


What if we have other fields but don't have additionalProperties?
Just to make sure what this means on my end.

'additionalProperties' is all I can see from the api response for now. If there is anything more, we can cope with it later.

Yeah, we can do that later.

govalt

Could you let me know your ideas?

Signed-off-by: Pianist038801 <[email protected]>

govalt

LGTM!

## [0.25.1](http://github.com/lyft/flyteconsole/compare/v0.25.0...v0.25.1) (2021-09-13) ### Bug Fixes * show field types on json launch form ([#199](http://github.com/lyft/flyteconsole/issues/199)) ([a42b9f8](http://github.com/lyft/flyteconsole/commit/a42b9f8520fcd24dee752111e606ad9ae9bd88f5)) * this is rfc, do not deploy until resolved; details in comments ([#172](http://github.com/lyft/flyteconsole/issues/172)) ([67dd183](http://github.com/lyft/flyteconsole/commit/67dd18397caf40e350da40e0672e500eaa9f338a))

flyte-bot · 2021-09-13T15:48:25Z

🎉 This PR is included in version 0.25.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Signed-off-by: Pianist038801 <[email protected]> Co-authored-by: Pianist038801 <[email protected]> Signed-off-by: Jason Porter <[email protected]>

## [0.25.1](http://github.com/lyft/flyteconsole/compare/v0.25.0...v0.25.1) (2021-09-13) ### Bug Fixes * show field types on json launch form ([#199](http://github.com/lyft/flyteconsole/issues/199)) ([a42b9f8](http://github.com/lyft/flyteconsole/commit/a42b9f8520fcd24dee752111e606ad9ae9bd88f5)) * this is rfc, do not deploy until resolved; details in comments ([#172](http://github.com/lyft/flyteconsole/issues/172)) ([67dd183](http://github.com/lyft/flyteconsole/commit/67dd18397caf40e350da40e0672e500eaa9f338a)) Signed-off-by: Jason Porter <[email protected]>

Signed-off-by: Pianist038801 <[email protected]> Co-authored-by: Pianist038801 <[email protected]> Signed-off-by: Jason Porter <[email protected]>

## [0.25.1](http://github.com/lyft/flyteconsole/compare/v0.25.0...v0.25.1) (2021-09-13) ### Bug Fixes * show field types on json launch form ([#199](http://github.com/lyft/flyteconsole/issues/199)) ([a42b9f8](http://github.com/lyft/flyteconsole/commit/a42b9f8520fcd24dee752111e606ad9ae9bd88f5)) * this is rfc, do not deploy until resolved; details in comments ([#172](http://github.com/lyft/flyteconsole/issues/172)) ([67dd183](http://github.com/lyft/flyteconsole/commit/67dd18397caf40e350da40e0672e500eaa9f338a)) Signed-off-by: Jason Porter <[email protected]>

* feat: add workflow versions table Signed-off-by: csirius <[email protected]> Signed-off-by: Jason Porter <[email protected]> * chore(release): Release 0.25.0 [skip ci] # [0.25.0](http://github.com/lyft/flyteconsole/compare/v0.24.0...v0.25.0) (2021-08-31) ### Features * add workflow versions table ([#193](http://github.com/lyft/flyteconsole/issues/193)) ([6fff87e](http://github.com/lyft/flyteconsole/commit/6fff87e40007fd15faae634eb6402045c067dd2c)) Signed-off-by: Jason Porter <[email protected]> * improvement: show proper error message for aborted workflows (#195) * improvement: show proper error message for aborted workflows Signed-off-by: Pianist038801 <[email protected]> * improvement: show abort message in the execution list Signed-off-by: Pianist038801 <[email protected]> Co-authored-by: Pianist038801 <[email protected]> Signed-off-by: Jason Porter <[email protected]> * Fix/versions executions gap (#197) * feat: add workflow versions table Signed-off-by: csirius <[email protected]> * fix: space between versions and executions table Signed-off-by: csirius <[email protected]> Signed-off-by: Jason Porter <[email protected]> * feat: workflow version details page Signed-off-by: csirius <[email protected]> Signed-off-by: Jason Porter <[email protected]> * Pre merge checkin Signed-off-by: Jason Porter <[email protected]> * fix: this is rfc, do not deploy until resolved; details in comments (#172) * fix: this is rfc, do not deploy until resolved; details in comments Signed-off-by: Jason Porter <[email protected]> * fix: this is rfc, do not deploy until resolved; details in comments note: deploying with caution; the believe if that it was incorrect to use meta. Signed-off-by: Jason Porter <[email protected]> * fix: show field types on json launch form (#199) Signed-off-by: Pianist038801 <[email protected]> Co-authored-by: Pianist038801 <[email protected]> Signed-off-by: Jason Porter <[email protected]> * chore(release): Release 0.25.1 [skip ci] ## [0.25.1](http://github.com/lyft/flyteconsole/compare/v0.25.0...v0.25.1) (2021-09-13) ### Bug Fixes * show field types on json launch form ([#199](http://github.com/lyft/flyteconsole/issues/199)) ([a42b9f8](http://github.com/lyft/flyteconsole/commit/a42b9f8520fcd24dee752111e606ad9ae9bd88f5)) * this is rfc, do not deploy until resolved; details in comments ([#172](http://github.com/lyft/flyteconsole/issues/172)) ([67dd183](http://github.com/lyft/flyteconsole/commit/67dd18397caf40e350da40e0672e500eaa9f338a)) Signed-off-by: Jason Porter <[email protected]> * Minor fixes Signed-off-by: Jason Porter <[email protected]> * Feat/version details (#198) * feat: add workflow versions table Signed-off-by: csirius <[email protected]> * feat: workflow version details page Signed-off-by: csirius <[email protected]> Signed-off-by: Jason Porter <[email protected]> * fix: repopulate struct input fields on relaunch form (#201) Signed-off-by: Pianist038801 <[email protected]> Co-authored-by: Pianist038801 <[email protected]> Signed-off-by: Jason Porter <[email protected]> * Graph ux feature add legend (#196) * Checkin and merge to master Signed-off-by: Jason Porter <[email protected]> * fixed one more Signed-off-by: Jason Porter <[email protected]> * chore(release): Release 0.25.2 [skip ci] ## [0.25.2](http://github.com/lyft/flyteconsole/compare/v0.25.1...v0.25.2) (2021-09-16) ### Bug Fixes * repopulate struct input fields on relaunch form ([#201](http://github.com/lyft/flyteconsole/issues/201)) ([950e080](http://github.com/lyft/flyteconsole/commit/950e080a2c52c6294630f0ffd1410b0e45b50a8d)) Signed-off-by: Jason Porter <[email protected]> * final before pr Signed-off-by: Jason Porter <[email protected]> * Fixed issues created by bad rebase Signed-off-by: Jason Porter <[email protected]> * Fixed more merge issues Signed-off-by: Jason Porter <[email protected]> Co-authored-by: csirius <[email protected]> Co-authored-by: flyte bot <[email protected]> Co-authored-by: pianist <[email protected]> Co-authored-by: Pianist038801 <[email protected]> Co-authored-by: csirius <[email protected]>

Pianist038801 requested review from jsonporter and govalt September 10, 2021 18:02

Pianist038801 force-pushed the fix/show-field-types-on-json-launch-form branch from 226191d to 8399e6d Compare September 10, 2021 18:03

govalt reviewed Sep 10, 2021

View reviewed changes

govalt requested changes Sep 10, 2021

View reviewed changes

fix: show field types on json launch form

d7368f2

Signed-off-by: Pianist038801 <[email protected]>

Pianist038801 force-pushed the fix/show-field-types-on-json-launch-form branch from 8399e6d to d7368f2 Compare September 13, 2021 14:40

govalt approved these changes Sep 13, 2021

View reviewed changes

jsonporter merged commit a42b9f8 into master Sep 13, 2021

flyte-bot added the released label Sep 13, 2021

jsonporter pushed a commit that referenced this pull request Sep 17, 2021

fix: show field types on json launch form (#199)

7f3265b

Signed-off-by: Pianist038801 <[email protected]> Co-authored-by: Pianist038801 <[email protected]> Signed-off-by: Jason Porter <[email protected]>

jsonporter pushed a commit that referenced this pull request Sep 17, 2021

fix: show field types on json launch form (#199)

f56cc53

Signed-off-by: Pianist038801 <[email protected]> Co-authored-by: Pianist038801 <[email protected]> Signed-off-by: Jason Porter <[email protected]>

anrusina deleted the fix/show-field-types-on-json-launch-form branch January 13, 2022 00:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: show field types on json launch form #199

fix: show field types on json launch form #199

Pianist038801 commented Sep 10, 2021

codecov bot commented Sep 10, 2021 •

edited

Loading

govalt Sep 10, 2021

Pianist038801 Sep 13, 2021

Pianist038801 Sep 13, 2021

govalt Sep 13, 2021

govalt Sep 10, 2021

Pianist038801 Sep 13, 2021

govalt Sep 13, 2021

govalt left a comment

govalt left a comment

flyte-bot commented Sep 13, 2021

fix: show field types on json launch form #199

fix: show field types on json launch form #199

Conversation

Pianist038801 commented Sep 10, 2021

Type

Are all requirements met?

Tracking Issue

codecov bot commented Sep 10, 2021 • edited Loading

Codecov Report

govalt Sep 10, 2021

Choose a reason for hiding this comment

Pianist038801 Sep 13, 2021

Choose a reason for hiding this comment

Pianist038801 Sep 13, 2021

Choose a reason for hiding this comment

govalt Sep 13, 2021

Choose a reason for hiding this comment

govalt Sep 10, 2021

Choose a reason for hiding this comment

Pianist038801 Sep 13, 2021

Choose a reason for hiding this comment

govalt Sep 13, 2021

Choose a reason for hiding this comment

govalt left a comment

Choose a reason for hiding this comment

govalt left a comment

Choose a reason for hiding this comment

flyte-bot commented Sep 13, 2021

codecov bot commented Sep 10, 2021 •

edited

Loading