Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate the Launch form #4

Merged
merged 5 commits into from
Sep 4, 2019
Merged

Integrate the Launch form #4

merged 5 commits into from
Sep 4, 2019

Conversation

schottra
Copy link
Contributor

@schottra schottra commented Sep 3, 2019

  • Added a button to the WorkflowDetailsHeader to initiate launch
  • Added some state to WorkflowDetails to handle showing a MUI Dialog with our form inside it
  • Changed some of the launch form components to use MUI Dialog* components instead.
  • Updated props for the form so that a partial workflow id can be passed, as well as a close handler
  • Updated styling of the form to make sure we have enough room to show the versions list.
  • Implemented the API call for creating an execution
  • Implemented logic in the form's submission handler
  • Added sort queries for search results and the pre-populated workflow version list
  • Moved my 'latest' tagging logic to the pre-populated list, where it belongs. 😅
  • Added an effect to select the latest version of the workflow by default so that the form should be able to load straight to inputs without any user action. They can always change the workflow version if desired.
    IntegratedLaunchForm

@schottra schottra requested a review from mrmcduff September 3, 2019 23:18
@schottra schottra merged commit 7af5a7c into launch Sep 4, 2019
@schottra schottra deleted the integrate-launch branch September 4, 2019 18:21
anrusina added a commit that referenced this pull request Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants