Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: created_at #620

Closed
wants to merge 1 commit into from
Closed

chore: created_at #620

wants to merge 1 commit into from

Conversation

ursucarina
Copy link
Contributor

Signed-off-by: Carina Ursu [email protected]

Read then delete this section

- Make sure to use a concise title for the pull-request.

- Use #patch, #minor or #major in the pull-request title to bump the corresponding version. Otherwise, the patch version
will be bumped. More details

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Carina Ursu <[email protected]>
@olga-union olga-union changed the base branch from master to devmain October 17, 2022 18:28
@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #620 (558ee6a) into devmain (919e90c) will increase coverage by 1.89%.
The diff coverage is 70.42%.

@@             Coverage Diff             @@
##           devmain     #620      +/-   ##
===========================================
+ Coverage    67.18%   69.08%   +1.89%     
===========================================
  Files          413      440      +27     
  Lines         9295    10434    +1139     
  Branches      1630     1789     +159     
===========================================
+ Hits          6245     7208     +963     
- Misses        3050     3226     +176     
Impacted Files Coverage Δ
...zapp/console/src/basics/FeatureFlags/AdminFlag.tsx 94.11% <ø> (ø)
...p/console/src/basics/FeatureFlags/FeatureFlags.tsx 93.54% <ø> (ø)
...p/console/src/basics/FeatureFlags/defaultConfig.ts 100.00% <ø> (ø)
...ges/zapp/console/src/basics/FeatureFlags/index.tsx 100.00% <ø> (ø)
.../console/src/basics/LocalCache/ContextProvider.tsx 89.65% <ø> (ø)
...app/console/src/basics/LocalCache/defaultConfig.ts 100.00% <ø> (ø)
...kages/zapp/console/src/basics/LocalCache/index.tsx 100.00% <ø> (ø)
...ole/src/basics/LocalCache/onlyMineDefaultConfig.ts 100.00% <ø> (ø)
packages/zapp/console/src/common/env.ts 100.00% <ø> (ø)
packages/zapp/console/src/common/layout.ts 100.00% <ø> (ø)
... and 769 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@olga-union olga-union changed the base branch from devmain to master October 17, 2022 18:52
@olga-union
Copy link
Contributor

Integrated in #621

@olga-union olga-union closed this Oct 18, 2022
@olga-union olga-union deleted the carina/fix branch October 18, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants