chore: fix filters #621

olga-union · 2022-10-18T15:00:36Z

TL;DR

Post-refactor fix of the filters behavior in Table tab view.

Type

Bug Fix
Feature
Plugin
Chore

Are all requirements met?

Code completed
Smoke tested
Unit tests added

Demo

Screen.Recording.2022-10-18.at.4.09.22.PM.mov

Tracking Issue

fixes https://github.com/flyteorg/flyteconsole/issues/617

Follow-up issue

NA

Signed-off-by: Nastya Rusina <[email protected]>

Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Carina Ursu <[email protected]>

Signed-off-by: eugenejahn <[email protected]>

* ci: move storybook related packages to top level * ci: ensure that lint can be run in PR checks * ci: allow to run tests linux setup Signed-off-by: Nastya Rusina <[email protected]>

Signed-off-by: eugenejahn <[email protected]>

#436) * ci: ensure unified tsconfig and remove mocks,test,stories from build * ci: move certificates into certificate folder inside script Signed-off-by: Nastya Rusina <[email protected]>

* fix: issue 398 * fix: prevent parent onclick event trigger Signed-off-by: eugenejahn <[email protected]>

* fix: unable to view all the workflow versions Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Carina Ursu <[email protected]>

* chore(tsc): exclude test/stories/mock files only from build Signed-off-by: Nastya Rusina <[email protected]>

Signed-off-by: Nastya Rusina <[email protected]>

* chore: support for StructuredDataSet Input/Output type Signed-off-by: Carina Ursu <[email protected]> * chore: add tests Signed-off-by: Carina Ursu <[email protected]> * chore: add package Signed-off-by: Carina Ursu <[email protected]> * chore: resolving local package issue Signed-off-by: Carina Ursu <[email protected]> * chore: yarn lock Signed-off-by: Carina Ursu <[email protected]> * chore: stories Signed-off-by: Carina Ursu <[email protected]> * chore: fix associative arrays in copy functionality Signed-off-by: Carina Ursu <[email protected]> * chore: fix scalar stories Signed-off-by: Carina Ursu <[email protected]> * chore: oops Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> * chore: revert old viewer to original Signed-off-by: Carina Ursu <[email protected]> * chore: fix Signed-off-by: Carina Ursu <[email protected]> * chore: remove non-null assertion Signed-off-by: Carina Ursu <[email protected]> * chore: fix types Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> * chore: fix tests Signed-off-by: Carina Ursu <[email protected]> * chore: fix test types Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Carina Ursu <[email protected]>

…scode setup properly (#458) * chore: separate AppInfo * chore: vscode properly understands @flyteconsole * chore: add basics/locale entry * test: add storybooks and tests * test: fix istanbul test-coverage issue by binding babel versions Signed-off-by: Nastya Rusina <[email protected]>

* ci: minimize babel presence Signed-off-by: Nastya Rusina <[email protected]>

* fix: update node executions to display map tasks * fix: update map task logs styles * test: add/update unit tests * fix: fix flickering and unnecessary re-renders Signed-off-by: Olga Nad <[email protected]>

* ci: resolve docker build issues * chore: remove unneeded changes Signed-off-by: Nastya Rusina <[email protected]>

* chore: fix Signed-off-by: Carina Ursu <[email protected]> * chore: remove console Signed-off-by: Carina Ursu <[email protected]> * chore: add cherio o=to package Signed-off-by: Carina Ursu <[email protected]> * chore: add cherio o=to package Signed-off-by: Carina Ursu <[email protected]> * chore: fix start prod Signed-off-by: Carina Ursu <[email protected]> * chore: fix start prod Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Carina Ursu <[email protected]>

Signed-off-by: Nastya <[email protected]>

made the entities component become more generic that can support Workflow, Task, and others added the inputs and outputs to task details page added the versions table in task details page added the version details page added task details link in node side panel Signed-off-by: eugenejahn <[email protected]> Co-authored-by: Eugene Jahn <[email protected]>

Signed-off-by: Nastya Rusina <[email protected]> Co-authored-by: Nastya Rusina <[email protected]>

* hotfix ci pipeline Signed-off-by: Yuvraj <[email protected]> * more changes Signed-off-by: Yuvraj <[email protected]> Co-authored-by: Yuvraj <[email protected]>

fix: inputHelpers InputProps Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Carina Ursu <[email protected]>

* fix: fix test of launchform Signed-off-by: James <[email protected]> * fix: inputHelpers tests regression Signed-off-by: Olga Nad <[email protected]> * fix: update tests description Signed-off-by: Olga Nad <[email protected]> * fix: spelling typo Signed-off-by: Olga Nad <[email protected]> Signed-off-by: James <[email protected]> Signed-off-by: Olga Nad <[email protected]> Co-authored-by: Olga Nad <[email protected]>

Signed-off-by: Jason Porter <[email protected]> Signed-off-by: Jason Porter <[email protected]>

Minor change Signed-off-by: Jason Porter <[email protected]> Signed-off-by: Jason Porter <[email protected]>

…#582) Signed-off-by: Olga Nad <[email protected]> Signed-off-by: Olga Nad <[email protected]>

Signed-off-by: Flyte-Bot <[email protected]> Signed-off-by: Flyte-Bot <[email protected]> Co-authored-by: flyte-bot <[email protected]>

* fix: add BASE_URL to dev startup, open deeply nested urls Signed-off-by: Carina Ursu <[email protected]> * fix: remove debug code Signed-off-by: Carina Ursu <[email protected]> * chore: empty BASE_URL handling Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Carina Ursu <[email protected]>

* fix: add default disabled state for only mine filter Signed-off-by: Olga Nad <[email protected]> * fix: tests Signed-off-by: Olga Nad <[email protected]> * fix: use api context to default filter state Signed-off-by: Olga Nad <[email protected]> * fix: revert test updates Signed-off-by: Olga Nad <[email protected]> Signed-off-by: Olga Nad <[email protected]>

Signed-off-by: Flyte-Bot <[email protected]> Signed-off-by: Flyte-Bot <[email protected]> Co-authored-by: flyte-bot <[email protected]>

* progress * Fixed * Removed debug code Signed-off-by: Jason Porter <[email protected]> Signed-off-by: Jason Porter <[email protected]>

chore: enable deeplinks in development Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Carina Ursu <[email protected]>

Signed-off-by: Jason Porter <[email protected]> Signed-off-by: Jason Porter <[email protected]>

…o devmain

…to devmain

Signed-off-by: Olga Nad <[email protected]>

codecov · 2022-10-18T21:36:38Z

Codecov Report

Merging #621 (43fc397) into devmain (bc2dd8e) will increase coverage by 0.42%.
The diff coverage is 74.25%.

@@             Coverage Diff             @@
##           devmain     #621      +/-   ##
===========================================
+ Coverage    67.35%   67.77%   +0.42%     
===========================================
  Files          398      443      +45     
  Lines         9296    10526    +1230     
  Branches      1590     1805     +215     
===========================================
+ Hits          6261     7134     +873     
- Misses        3035     3392     +357

Impacted Files	Coverage Δ
...zapp/console/src/basics/FeatureFlags/AdminFlag.tsx	`94.11% <ø> (ø)`
...p/console/src/basics/FeatureFlags/FeatureFlags.tsx	`93.54% <ø> (ø)`
...ges/zapp/console/src/basics/FeatureFlags/index.tsx	`100.00% <ø> (ø)`
packages/zapp/console/src/common/env.ts	`100.00% <ø> (ø)`
packages/zapp/console/src/common/layout.ts	`100.00% <ø> (ø)`
packages/zapp/console/src/common/linkify.ts	`100.00% <ø> (ø)`
packages/zapp/console/src/common/log.ts	`100.00% <ø> (ø)`
packages/zapp/console/src/common/promiseUtils.ts	`0.00% <ø> (ø)`
packages/zapp/console/src/common/timer.ts	`0.00% <ø> (ø)`
packages/zapp/console/src/common/timezone.ts	`100.00% <ø> (ø)`
... and 399 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

anrusina and others added 30 commits May 17, 2022 18:05

chore: move src to a new location

286e1f8

Signed-off-by: Nastya Rusina <[email protected]>

ci: allow branch to be built again

0efd1df

Signed-off-by: Nastya Rusina <[email protected]>

chore: replace link to github repository to a proper one

b49fed5

Signed-off-by: Nastya Rusina <[email protected]>

ci: basic test and test-coverage setup

9503a4c

Signed-off-by: Nastya Rusina <[email protected]>

chore: add first plugin package

3091c4b

Signed-off-by: Nastya Rusina <[email protected]>

chore: allow to start test from main directory

3573659

Signed-off-by: Nastya Rusina <[email protected]>

ci: update lowest mkdirp version (#423)

8d1fef9

Signed-off-by: Nastya Rusina <[email protected]>

chore: add build scripts for console app (#429)

48a1c92

Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Carina Ursu <[email protected]>

fix: hide the legend (#435)

caaf5c2

Signed-off-by: eugenejahn <[email protected]>

ci: move storybook related packages to top level (#434)

133038a

* ci: move storybook related packages to top level * ci: ensure that lint can be run in PR checks * ci: allow to run tests linux setup Signed-off-by: Nastya Rusina <[email protected]>

fix: fix issue 386 (#437)

1651a6f

Signed-off-by: eugenejahn <[email protected]>

ci: ensure unified tsconfig and remove mocks, test, stories from build (

eeb551b

#436) * ci: ensure unified tsconfig and remove mocks,test,stories from build * ci: move certificates into certificate folder inside script Signed-off-by: Nastya Rusina <[email protected]>

Make whole row clickable to open TaskExecutionDetails panel (#444)

b6e9941

* fix: issue 398 * fix: prevent parent onclick event trigger Signed-off-by: eugenejahn <[email protected]>

ci: allow to start jest config for all project at once (#447)

b513280

minor: unable to view all the workflow versions (#446)

ecfdd4c

* fix: unable to view all the workflow versions Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Carina Ursu <[email protected]>

chore(tsc): exclude test/stories/mock files only from build (#451)

5b44539

* chore(tsc): exclude test/stories/mock files only from build Signed-off-by: Nastya Rusina <[email protected]>

ci: ensure that webpack too doesn't include test/mock/specs files (#452)

560b645

Signed-off-by: Nastya Rusina <[email protected]>

ci: minimize babel presence (#457)

acf3cb9

* ci: minimize babel presence Signed-off-by: Nastya Rusina <[email protected]>

fix: update node executions to display map tasks (#455)

38a4e96

* fix: update node executions to display map tasks * fix: update map task logs styles * test: add/update unit tests * fix: fix flickering and unnecessary re-renders Signed-off-by: Olga Nad <[email protected]>

ci: resolve docker build issues (#462)

c2ee154

* ci: resolve docker build issues * chore: remove unneeded changes Signed-off-by: Nastya Rusina <[email protected]>

Chore: Rebase devmain on top of master (#464)

e84a3c0

fix: ensure that admin version is fully shown (#465)

0853680

chore: rebase on top of master

1859cf5

Signed-off-by: Nastya <[email protected]>

fix: trigger release #patch (#477)

42d2632

Signed-off-by: Nastya <[email protected]>

chore: update Readme with python note + package version update (#486)

821299e

Signed-off-by: Nastya Rusina <[email protected]> Co-authored-by: Nastya Rusina <[email protected]>

hotfix ci pipeline (#487)

c25daea

* hotfix ci pipeline Signed-off-by: Yuvraj <[email protected]> * more changes Signed-off-by: Yuvraj <[email protected]> Co-authored-by: Yuvraj <[email protected]>

ursucarina and others added 18 commits September 7, 2022 08:53

#minor: inputHelpers InputProps (#579)

f027c43

fix: inputHelpers InputProps Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Carina Ursu <[email protected]>

Pruning some unused packages (#583)

250ab96

Signed-off-by: Jason Porter <[email protected]> Signed-off-by: Jason Porter <[email protected]>

feat: minor change (#584)

ce59d55

Minor change Signed-off-by: Jason Porter <[email protected]> Signed-off-by: Jason Porter <[email protected]>

fix: floor seconds to int in the edge case moment returns it as float (…

786bced

…#582) Signed-off-by: Olga Nad <[email protected]> Signed-off-by: Olga Nad <[email protected]>

Update Flyteidl version (#575)

9a1ae4c

Signed-off-by: Flyte-Bot <[email protected]> Signed-off-by: Flyte-Bot <[email protected]> Co-authored-by: flyte-bot <[email protected]>

Update Flyteidl version (#590)

64e55be

Signed-off-by: Flyte-Bot <[email protected]> Signed-off-by: Flyte-Bot <[email protected]> Co-authored-by: flyte-bot <[email protected]>

Launch plan ref v2 (#601)

b9eed42

* progress * Fixed * Removed debug code Signed-off-by: Jason Porter <[email protected]> Signed-off-by: Jason Porter <[email protected]>

fix: enable deeplinks in development (#602)

d649546

chore: enable deeplinks in development Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Carina Ursu <[email protected]>

chore: release 1.3.5 (#605)

b9ffd81

Signed-off-by: Jason Porter <[email protected]> Signed-off-by: Jason Porter <[email protected]>

Merge branch 'master' of https://github.com/flyteorg/flyteconsole int…

2139738

…o devmain

Merge branch 'devmain' of https://github.com/flyteorg/flyteconsole in…

907363a

…to devmain

Merge branch 'devmain' of https://github.com/flyteorg/flyteconsole in…

bf7a750

…to devmain

Merge branch 'devmain' of https://github.com/flyteorg/flyteconsole in…

8d56eb9

…to devmain

Merge branch 'devmain' of https://github.com/flyteorg/flyteconsole in…

cb7cc32

…to devmain

fix: filters in node executions table view

9ee47b3

Signed-off-by: Olga Nad <[email protected]>

olga-union mentioned this pull request Oct 18, 2022

chore: created_at #620

Closed

8 tasks

fix: effect dependency and tests

43fc397

Signed-off-by: Olga Nad <[email protected]>

olga-union marked this pull request as ready for review October 18, 2022 21:14

olga-union requested review from a team, ursucarina, eugenejahn and james-union and removed request for a team October 18, 2022 21:14

jsonporter approved these changes Oct 21, 2022

View reviewed changes

jsonporter merged commit 1542da0 into devmain Oct 21, 2022

jsonporter deleted the olga-union/fix-filters branch October 21, 2022 16:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: fix filters #621

chore: fix filters #621

olga-union commented Oct 18, 2022 •

edited

Loading

codecov bot commented Oct 18, 2022

chore: fix filters #621

chore: fix filters #621

Conversation

olga-union commented Oct 18, 2022 • edited Loading

TL;DR

Type

Are all requirements met?

Demo

Tracking Issue

Follow-up issue

codecov bot commented Oct 18, 2022

Codecov Report

olga-union commented Oct 18, 2022 •

edited

Loading