Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Flytedecks support for TLRO #757

Merged
merged 4 commits into from
May 15, 2023
Merged

Export Flytedecks support for TLRO #757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4f7228
fix: export ExecutionNodeDeck with few css changes
james-union May 12, 2023
685b4ae
Merge branch 'master' into james/export-flyte-deck-comp
james-union May 12, 2023
9f9adfb
fix: upgrade version
james-union May 12, 2023
63b6c60
chore: yarn.lock
ursucarina May 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/console/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@flyteorg/console",
"version": "0.0.31",
"version": "0.0.32",
"description": "Flyteconsole main app module",
"main": "./dist/index.js",
"module": "./lib/index.js",
Expand Down
3 changes: 0 additions & 3 deletions packages/console/src/components/Executions/ExecutionDetails/ExecutionDetailsActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@ const useStyles = makeStyles((theme: Theme) => {
maxHeight: `calc(100% - ${theme.spacing(12)}px)`,
height: theme.spacing(90),
width: theme.spacing(110),
'& iframe': {
border: 'none',
},
},
dialogTitle: {
display: 'flex',
Expand Down
6 changes: 5 additions & 1 deletion packages/console/src/components/Executions/ExecutionDetails/ExecutionNodeDeck.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,19 @@ import { Core } from '@flyteorg/flyteidl-types';
/** Fetches and renders the deck data for a given `nodeExecutionId` */
export const ExecutionNodeDeck: React.FC<{
nodeExecutionId: Core.NodeExecutionIdentifier;
}> = ({ nodeExecutionId }) => {
className?: string;
}> = ({ nodeExecutionId, className = '' }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need = ''

const downloadLink = useDownloadLink(nodeExecutionId);

return (
<WaitForData {...downloadLink}>
<iframe
title="deck"
width="100%"
height="100%"
src={downloadLink?.value?.signedUrl?.[0]}
className={className}
style={{ border: 'none' }}
/>
</WaitForData>
);
Expand Down
1 change: 1 addition & 0 deletions packages/console/src/components/Executions/ExecutionDetails/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
export * from './ExecutionDetails';
export * from './ExecutionDetailsActions';
export * from './useExecutionNodeViewsState';
export * from './ExecutionNodeDeck';
2 changes: 1 addition & 1 deletion website/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
},
"dependencies": {
"@flyteorg/common": "^0.0.4",
"@flyteorg/console": "^0.0.31",
"@flyteorg/console": "^0.0.32",
"long": "^4.0.0",
"protobufjs": "~6.11.3",
"react-ga4": "^1.4.1",
Expand Down
4 changes: 2 additions & 2 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2020,7 +2020,7 @@ __metadata:
resolution: "@flyteconsole/client-app@workspace:website"
dependencies:
"@flyteorg/common": ^0.0.4
"@flyteorg/console": ^0.0.31
"@flyteorg/console": ^0.0.32
"@types/long": ^3.0.32
long: ^4.0.0
protobufjs: ~6.11.3
Expand Down Expand Up @@ -2059,7 +2059,7 @@ __metadata:
languageName: unknown
linkType: soft

"@flyteorg/console@^0.0.31, @flyteorg/console@workspace:packages/console":
"@flyteorg/console@^0.0.32, @flyteorg/console@workspace:packages/console":
version: 0.0.0-use.local
resolution: "@flyteorg/console@workspace:packages/console"
dependencies:
Expand Down