Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Flytedecks support for TLRO #757

Merged
merged 4 commits into from
May 15, 2023
Merged

Conversation

james-union
Copy link
Contributor

Read then delete this section

Export FlyteNodeDecks component

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
flyteorg/flyte#2051

@james-union james-union self-assigned this May 12, 2023
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #757 (63b6c60) into master (b7c4b80) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #757   +/-   ##
=======================================
  Coverage   65.90%   65.90%           
=======================================
  Files         489      489           
  Lines       11914    11915    +1     
  Branches     2195     2196    +1     
=======================================
+ Hits         7852     7853    +1     
  Misses       4062     4062           
Impacted Files Coverage Δ
...tions/ExecutionDetails/ExecutionDetailsActions.tsx 23.88% <ø> (ø)
.../Executions/ExecutionDetails/ExecutionNodeDeck.tsx 71.42% <100.00%> (ø)
...rc/components/Executions/ExecutionDetails/index.ts 100.00% <100.00%> (ø)

ursucarina
ursucarina previously approved these changes May 12, 2023
@@ -6,15 +6,19 @@ import { Core } from '@flyteorg/flyteidl-types';
/** Fetches and renders the deck data for a given `nodeExecutionId` */
export const ExecutionNodeDeck: React.FC<{
nodeExecutionId: Core.NodeExecutionIdentifier;
}> = ({ nodeExecutionId }) => {
className?: string;
}> = ({ nodeExecutionId, className = '' }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need = ''

Signed-off-by: Carina Ursu <[email protected]>
@ursucarina ursucarina merged commit 22ed97f into master May 15, 2023
@ursucarina ursucarina deleted the james/export-flyte-deck-comp branch May 15, 2023 15:02
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

wild-endeavor added a commit to flyteorg/flyte that referenced this pull request May 22, 2023
Signed-off-by: Yee Hing Tong <[email protected]>

### Admin - v1.1.100
* Inject user identifier to ExecutionSpec by @ByronHsu in flyteorg/flyteadmin#549
* Fix flaky test by @eapolinario in flyteorg/flyteadmin#563
* Add oauth http proxy for external server & Extract email from azure claim by @ByronHsu in flyteorg/flyteadmin#553
* Remove single task execution default timeout by @hamersaw in flyteorg/flyteadmin#564
* Revert conditional setting of SecurityContext when launching security context by @wild-endeavor in flyteorg/flyteadmin#566

### Console - v1.8.2
* Export Flytedecks support for TLRO by @james-union in flyteorg/flyteconsole#757
* fix: filter executions by version and name by @ursucarina in flyteorg/flyteconsole#758
* fix: task recent runs should filter by version by @ursucarina in flyteorg/flyteconsole#759
* Bug: Execution Page's back button returns Workflows route from Launch Plan route #patch by @FrankFlitton in flyteorg/flyteconsole#760
* chore: add item when mapped task by @jsonporter in flyteorg/flyteconsole#761
* Feature: Fullview Flyte Deck modal by @FrankFlitton in flyteorg/flyteconsole#764

### Propeller - v1.1.90
* Add grpc plugin to loader.go by @pingsutw in flyteorg/flytepropeller#562
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants