This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
pytorch.proto and respective changes #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 8, 2020
EngHabu
reviewed
May 8, 2020
|
|
||
| option go_package = "github.com/lyft/flyteidl/gen/pb-go/flyteidl/plugins"; | ||
|
|
||
| message PyTorchOperatorTask { |
There was a problem hiding this comment.
Can you add some code comments here...
There was a problem hiding this comment.
I think we should call the plugin type, DistributedPytorchTraining?
There was a problem hiding this comment.
Also the comment then should be, this plugin enables distributed training for pytorch using "link to the Kubeflow operator" - What do you think @igorvalko ?
wild-endeavor
approved these changes
May 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
proto files and generated ones for pytorch Flyte plugin
Type
Are all requirements met?
Complete description
That's the part of pytorch Flyte plugin implementation.
Related PRs:
flyteorg/flytekit#112
flyteorg/flyteplugins#85
Tracking Issue
N/A
Follow-up issue
N/A