This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
pytorch plugin implementation #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 8, 2020
kumare3
reviewed
May 18, 2020
kumare3
reviewed
May 18, 2020
kumare3
reviewed
May 18, 2020
kumare3
reviewed
May 18, 2020
|
This is great stuff @igorvalko, once you change the flyteidl, you have a +1 from me |
kumare3
reviewed
May 28, 2020
| workers := pytorchTaskExtraArgs.GetWorkers() | ||
|
|
||
| jobSpec := ptOp.PyTorchJobSpec{ | ||
| TTLSecondsAfterFinished: nil, //60, // cleanup in 60 seconds after the job completion |
There was a problem hiding this comment.
ya you dont need to cleanup, we will automatically
kumare3
reviewed
May 28, 2020
| "github.com/lyft/flyteplugins/go/tasks/logs" | ||
| logUtils "github.com/lyft/flyteidl/clients/go/coreutils/logs" | ||
|
|
||
| //commonOp "github.com/kubeflow/common/pkg/apis/common/v1" // switch to real 'common' once https://github.com/kubeflow/pytorch-operator/issues/263 resolved |
There was a problem hiding this comment.
interesting call out. I think after this for all kubeflow operators, we can just have a flyte-kubeflow-commons where all status checking can be done inline
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
==========================================
+ Coverage 54.97% 55.92% +0.94%
==========================================
Files 91 93 +2
Lines 4660 4787 +127
==========================================
+ Hits 2562 2677 +115
- Misses 1821 1827 +6
- Partials 277 283 +6
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Pytorch plugin for Flyte that leverages https://github.com/kubeflow/pytorch-operator to run distributed pytorch jobs on k8s.
Type
Are all requirements met?
Complete description
Pytorch plugin for Flyte that leverages https://github.com/kubeflow/pytorch-operator to run distributed pytorch jobs on k8s.
Related PRs:
flyteorg/flyteidl#61
flyteorg/flytekit#112
Tracking Issue
NA
Follow-up issue
NA