Strip password when reading from file #1162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
wild-endeavor
requested review from
kumare3,
eapolinario and
pingsutw
as code owners
wild-endeavor
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1162 +/- ##
=======================================
Coverage 68.51% 68.51%
=======================================
Files 288 288
Lines 26085 26088 +3
Branches 2918 2918
=======================================
+ Hits 17871 17874 +3
Misses 7735 7735
Partials 479 479
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
closing see #1163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Strip the password when reading from a file.
Type
Are all requirements met?
Complete description
This is tangentially possibly related to flyteorg/flyte#2849. Found this nit when investigating that issue, but not sure if this is what the user was experiencing or if there is a different bug somewhere.
Tracking Issue
flyteorg/flyte#2849