Feat: Allow disabling rich tracebacks via env var #1695
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
In
flytekit==1.6.0
rich tracebacks were introduced (#1582).Before, exceptions were shown like this:
After, they are shown like this:
This happens as long as
import flytekit
is called somewhere in the imported code base, also when not directly working with flyte.Style ultimately is a question of taste but several of our engineers have complained about this change:
Because of this, in this PR I propose to introduce an environment variable which disables rich tracebacks. I chose a naming inspired by
"FLYTE_SDK_LOGGING_LEVEL"
or"FLYTE_SDK_LOGGING_FORMAT"
inflytekit/loggers.py
.Would this change be be acceptable to you @cosmicBboy @kumare3 @eapolinario ?
Type
Are all requirements met?
Complete description
NA
Tracking Issue
NA
Follow-up issue
NA