Fix: Disable rich logging handler when env var FLYTE_SDK_RICH_TRACEBACKS=0
is set
#1760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Are all requirements met?
Complete description
In #1695 I introduced an environment variable called
FLYTE_SDK_RICH_TRACEBACKS
which, when set to 0, disables rich tracebacks.Setting this environment variable turns this
back into:
However, in this PR I overlooked that a
RichHandler
is added to the flytekit logger which also produces output in rich format. When executing this workflowwith
FLYTE_SDK_RICH_TRACEBACKS=0 python test.py
, the output still looks as follows:This PR disables this logger as well when the above mentioned environment variable is set.
Tracking Issue
NA
Follow-up issue
NA