Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert the order flytekit is installed in the case of plugins #719

Closed
wants to merge 2 commits into from

Conversation

eapolinario
Copy link
Collaborator

Signed-off-by: Eduardo Apolinario [email protected]

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/lyft/flyte/issues/

Follow-up issue

NA
OR
https://github.com/lyft/flyte/issues/

@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #719 (2c67769) into master (f03ecb6) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #719      +/-   ##
==========================================
+ Coverage   85.74%   85.76%   +0.01%     
==========================================
  Files         357      358       +1     
  Lines       29747    29778      +31     
  Branches     2428     2428              
==========================================
+ Hits        25507    25538      +31     
  Misses       3601     3601              
  Partials      639      639              
Impacted Files Coverage Δ
flytekit/core/python_function_task.py 84.61% <0.00%> (ø)
...ts/flytekit/unit/core/functools/test_decorators.py 100.00% <0.00%> (ø)
flytekit/core/tracker.py 83.07% <0.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f03ecb6...2c67769. Read the comment docs.

@eapolinario
Copy link
Collaborator Author

Closing this in favor of #721.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant