Force install of the git sha of flytekit for plugins #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #721 +/- ##
=======================================
Coverage 85.76% 85.76%
=======================================
Files 358 358
Lines 29778 29778
Branches 2428 2428
=======================================
Hits 25538 25538
Misses 3601 3601
Partials 639 639 Continue to review full report at Codecov.
|
wild-endeavor
changed the title
8 tasks
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario
previously approved these changes
Oct 22, 2021
eapolinario
reviewed
Oct 22, 2021
.github/workflows/pythonbuild.yml
Outdated
| @@ -91,6 +91,7 @@ jobs: | |||
| cd plugins/${{ matrix.plugin-names }} | |||
| # install in develop mode so setuptools doesn't override flytekit on current branch | |||
There was a problem hiding this comment.
can you remove this comment?
Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario
approved these changes
Oct 22, 2021
reverson
pushed a commit
to reverson/flytekit
that referenced
this pull request
May 27, 2022
Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: Robert Everson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yee Hing Tong [email protected]
TL;DR
Please replace this text with a description of what this PR accomplishes.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/lyft/flyte/issues/
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/