Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move plugin models to be alongside plugins, remove legacy Sagemaker, Pytorch, notebook, and Tensorflow plugins #736

Merged
merged 17 commits into from
Nov 4, 2021

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Nov 3, 2021

TL;DR

Copy the model files for plugins into the microlib that uses them. We're copying instead of moving to support legacy use-cases, but the old definitions will be removed in 1.0. Removing sagemaker because it's not used.

Type

  • Bug Fix
  • Feature
  • Plugin
  • Cleanup

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Delete.

Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #736 (71f8de0) into master (673e076) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #736      +/-   ##
==========================================
- Coverage   85.74%   85.60%   -0.15%     
==========================================
  Files         362      341      -21     
  Lines       29996    28917    -1079     
  Branches     2444     2382      -62     
==========================================
- Hits        25721    24755     -966     
+ Misses       3632     3528     -104     
+ Partials      643      634       -9     
Impacted Files Coverage Δ
flytekit/models/presto.py 80.00% <ø> (ø)
flytekit/models/qubole.py 96.36% <ø> (ø)
flytekit/models/task.py 92.00% <ø> (-0.13%) ⬇️
flytekit/plugins/__init__.py 100.00% <ø> (ø)
flytekit/sdk/tasks.py 76.19% <ø> (+0.43%) ⬆️
flytekit/common/interface.py 86.30% <0.00%> (-2.74%) ⬇️
flytekit/common/types/proto.py 75.88% <0.00%> (-2.13%) ⬇️
flytekit/engines/common.py 78.94% <0.00%> (-0.66%) ⬇️
flytekit/common/types/primitives.py 94.37% <0.00%> (-0.41%) ⬇️
...ker/flytekitplugins/awssagemaker/models/hpo_job.py
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 673e076...71f8de0. Read the comment docs.

Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
@wild-endeavor wild-endeavor marked this pull request as ready for review November 3, 2021 21:46
@wild-endeavor wild-endeavor changed the title [wip] Move plugin models to be alongside plugins Move plugin models to be alongside plugins Nov 3, 2021
Signed-off-by: Yee Hing Tong <[email protected]>
@wild-endeavor wild-endeavor changed the title Move plugin models to be alongside plugins Move plugin models to be alongside plugins, remove old Sagemaker plugin Nov 3, 2021
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario
eapolinario previously approved these changes Nov 3, 2021
flytekit/models/task.py Outdated Show resolved Hide resolved
flytekit/models/task.py Outdated Show resolved Hide resolved
Signed-off-by: Yee Hing Tong <[email protected]>
@wild-endeavor wild-endeavor changed the title Move plugin models to be alongside plugins, remove old Sagemaker plugin Move plugin models to be alongside plugins, remove legacy Sagemaker, Pytorch, notebook, and Tensorflow plugins Nov 3, 2021
Signed-off-by: Yee Hing Tong <[email protected]>
@wild-endeavor wild-endeavor merged commit ba29604 into master Nov 4, 2021
@eapolinario eapolinario mentioned this pull request Jan 14, 2022
8 tasks
reverson pushed a commit to reverson/flytekit that referenced this pull request May 27, 2022
…Pytorch, notebook, and Tensorflow plugins (flyteorg#736)

Signed-off-by: Yee Hing Tong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants