Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move plugin models to be alongside plugins, remove legacy Sagemaker, Pytorch, notebook, and Tensorflow plugins #736

Merged
merged 17 commits into from
Nov 4, 2021
Merged

Move plugin models to be alongside plugins, remove legacy Sagemaker, Pytorch, notebook, and Tensorflow plugins #736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c71a52e
move sagemaker models and remove tests
wild-endeavor Nov 3, 2021
46f579f
more stuff
wild-endeavor Nov 3, 2021
1873961
update sagemaker tests
wild-endeavor Nov 3, 2021
64264dd
remove old sagemaker tests
wild-endeavor Nov 3, 2021
9e8071e
make fmt
wild-endeavor Nov 3, 2021
85684e2
awssagemaker
wild-endeavor Nov 3, 2021
0be6c8e
awssagemaker models
wild-endeavor Nov 3, 2021
11d8736
one more fix
wild-endeavor Nov 3, 2021
4e0d451
more aws
wild-endeavor Nov 3, 2021
09d08f1
remove old sagemaker
wild-endeavor Nov 3, 2021
19d2453
remove old sagemaker
wild-endeavor Nov 3, 2021
9c02719
remove old sagemaker
wild-endeavor Nov 3, 2021
7b95ee5
remove test scripts
wild-endeavor Nov 3, 2021
24a9802
remove test scripts
wild-endeavor Nov 3, 2021
57575ad
remove test scripts
wild-endeavor Nov 3, 2021
dc5f745
remove more legacy plugins
wild-endeavor Nov 3, 2021
71f8de0
lint
wild-endeavor Nov 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pythonbuild.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
pip freeze
- name: Test with coverage
run: |
coverage run -m pytest tests/flytekit/unit tests/scripts
coverage run -m pytest tests/flytekit/unit
- name: Integration Tests with coverage
# https://github.com/actions/runner/issues/241#issuecomment-577360161
shell: 'script -q -e -c "bash {0}"'
Expand Down
2 changes: 0 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,10 @@ spellcheck: ## Runs a spellchecker over all code and documentation
.PHONY: test
test: lint ## Run tests
pytest tests/flytekit/unit
pytest tests/scripts

.PHONY: unit_test
unit_test:
pytest tests/flytekit/unit
pytest tests/scripts

requirements-spark2.txt: export CUSTOM_COMPILE_COMMAND := make requirements-spark2.txt
requirements-spark2.txt: requirements-spark2.in install-piptools
Expand Down
65 changes: 0 additions & 65 deletions flytekit/common/tasks/pytorch_task.py
View file
Open in desktop

This file was deleted.

109 changes: 0 additions & 109 deletions flytekit/common/tasks/sagemaker/built_in_training_job_task.py
View file
Open in desktop

This file was deleted.

173 changes: 0 additions & 173 deletions flytekit/common/tasks/sagemaker/custom_training_job_task.py
View file
Open in desktop

This file was deleted.

Loading